After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697220 - Fails to build against gtksourceview 3.8
Fails to build against gtksourceview 3.8
Status: RESOLVED FIXED
Product: giggle
Classification: Other
Component: UI: General
HEAD
Other Linux
: Normal normal
: ---
Assigned To: giggle-maint
giggle-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-03 20:28 UTC by Dominique Leuenberger
Modified: 2013-04-18 19:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Directly include gtksourcebuffer.h (1.38 KB, patch)
2013-04-03 20:29 UTC, Dominique Leuenberger 		none Details | Review
Include gtksource.h (1.50 KB, patch)
2013-04-18 11:59 UTC, Dominique Leuenberger 		none Details | Review

Description Dominique Leuenberger 2013-04-03 20:28:19 UTC 
Giggle 0.7 (and git master) fails to build against gtksourceview 3.8 with this error:

[  286s]   CCLD   giggle
[  287s] giggle-diff-view.o: In function `giggle_diff_view_init':
[  287s] /home/abuild/rpmbuild/BUILD/giggle-0.7/src/giggle-diff-view.c:550: undefined reference to `GTK_SOURCE_BUFFER'
[  287s] giggle-view-file.o: In function `giggle_view_file_init':
[  287s] /home/abuild/rpmbuild/BUILD/giggle-0.7/src/giggle-view-file.c:1524: undefined reference to `GTK_SOURCE_BUFFER'
[  287s] giggle-view-file.o: In function `view_file_set_source_code':
[  287s] /home/abuild/rpmbuild/BUILD/giggle-0.7/src/giggle-view-file.c:769: undefined reference to `GTK_SOURCE_BUFFER'
[  287s] /home/abuild/rpmbuild/BUILD/giggle-0.7/src/giggle-view-file.c:770: undefined reference to `GTK_SOURCE_BUFFER'
[  287s] giggle-view-file.o: In function `view_file_blame_job_callback':
[  287s] /home/abuild/rpmbuild/BUILD/giggle-0.7/src/giggle-view-file.c:824: undefined reference to `GTK_SOURCE_BUFFER'
[  287s] giggle-view-file.o:/home/abuild/rpmbuild/BUILD/giggle-0.7/src/giggle-view-file.c:604: more undefined references to `GTK_SOURCE_BUFFER' follow
[  287s] collect2: error: ld returned 1 exit status
[  287s] make[2]: *** [giggle] Error 1
[  287s] make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/giggle-0.7/src
Comment 1 Dominique Leuenberger 2013-04-03 20:29:07 UTC 
Created attachment 240542 [details] [review]
Directly include gtksourcebuffer.h

Until gtksourceview 3.7, it was included indirectly by gtksourceview.h.
Comment 2 Javier Jardón (IRC: jjardon) 2013-04-04 13:41:59 UTC 
Thanks for the bug report and the patch Dominique.

This has ben pushed in commit 9999a7ff573b7f3320c2065e8d0eaf0fea32a41b
Comment 3 Dominique Leuenberger 2013-04-18 11:59:03 UTC 
Created attachment 241819 [details] [review]
Include gtksource.h

Javier,

that patch was actually not the best solution I'm afraid (it causes other undefined failures).

I'd propose to revert it, and apply the new attached patch; the main issue is that gtksourceview change the name of the main header from gtksourceview.h to gtksource.h
Comment 4 Javier Jardón (IRC: jjardon) 2013-04-18 19:14:48 UTC 
Hi Dominique,

Ive reverted the patch and pushed your new one in 44490f7f78c3281c8fc4f38aa7226fc5955720a9

Thanks