After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697202 - Gnome-boxes automagically depends on ovirt
Gnome-boxes automagically depends on ovirt
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.8.x
Other Linux
: Normal minor
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-03 17:38 UTC by Maciej (Matthew) Piechotka
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Add-enable-ovirt-configure-option.patch (1.25 KB, patch)
2013-04-03 17:38 UTC, Maciej (Matthew) Piechotka 		reviewed Details | Review

Description Maciej (Matthew) Piechotka 2013-04-03 17:38:22 UTC 
Created attachment 240520 [details] [review]
0001-Add-enable-ovirt-configure-option.patch

Gnome-boxes automagically depends on ovirt library. While it does not cause problems for binary distributions it poses problems for the source-based ones (like Gentoo, Nix etc.) - see http://www.gentoo.org/proj/en/qa/automagic.xml for details (or say http://blog.flameeyes.eu/tag/automagic/ for problems it caused).

The added patch allows the user to add/remove ovirt feature while retaining default of automatic enabling/disabling feature.
Comment 1 Christophe Fergeau 2013-04-04 09:55:21 UTC 
Review of attachment 240520 [details] [review]:

::: configure.ac
@@ +111,3 @@
+                      [have_govirt=yes], [have_govirt=no]) ;;
+  "xno")
+    have_govirt = "xno" ;;

This case is missing handling of --enable-ovirt=foobar (stupid but valid if I'm not mistaken). I'd make this case behave as if "xyes" had been found. Patch looks good otherwise, thanks!
Comment 2 Christophe Fergeau 2013-04-08 11:14:39 UTC 
I've pushed a slightly modified version of this patch which errors out on --enable-ovirt=foobar, and with the have_govirt assignments fixed (the '=' must not be surrounded by spaces)
https://git.gnome.org/browse/gnome-boxes/commit/?id=4a1c8482e19e5f3bf86b1a663362b6045b5fa4d6