GNOME Bugzilla – Bug 697202
Gnome-boxes automagically depends on ovirt
Last modified: 2016-03-31 13:22:07 UTC
Created attachment 240520 [details] [review] 0001-Add-enable-ovirt-configure-option.patch Gnome-boxes automagically depends on ovirt library. While it does not cause problems for binary distributions it poses problems for the source-based ones (like Gentoo, Nix etc.) - see http://www.gentoo.org/proj/en/qa/automagic.xml for details (or say http://blog.flameeyes.eu/tag/automagic/ for problems it caused). The added patch allows the user to add/remove ovirt feature while retaining default of automatic enabling/disabling feature.
Review of attachment 240520 [details] [review]: ::: configure.ac @@ +111,3 @@ + [have_govirt=yes], [have_govirt=no]) ;; + "xno") + have_govirt = "xno" ;; This case is missing handling of --enable-ovirt=foobar (stupid but valid if I'm not mistaken). I'd make this case behave as if "xyes" had been found. Patch looks good otherwise, thanks!
I've pushed a slightly modified version of this patch which errors out on --enable-ovirt=foobar, and with the have_govirt assignments fixed (the '=' must not be surrounded by spaces) https://git.gnome.org/browse/gnome-boxes/commit/?id=4a1c8482e19e5f3bf86b1a663362b6045b5fa4d6