After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697188 - clean out-of-tree build fails
clean out-of-tree build fails
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-03 16:02 UTC by Simon McVittie
Modified: 2013-04-04 17:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Compile tp-lowlevel.vapi before libfolks_telepathy_la_vala.stamp (1.03 KB, patch)
2013-04-03 16:04 UTC, Simon McVittie 		accepted-commit_now Details | Review
libtpf-test.la: explicitly depend on telepathy-glib (781 bytes, patch)
2013-04-03 16:05 UTC, Simon McVittie 		none Details | Review
contactlist: copy .deps to the same place as .vapi if necessary (1.52 KB, patch)
2013-04-03 17:50 UTC, Simon McVittie 		accepted-commit_now Details | Review

Description Simon McVittie 2013-04-03 16:02:51 UTC 
After upgrading various GNOME libraries, I tried a clean out-of-tree build of Folks. It didn't work. Here are the patches that made it work for me.
Comment 1 Simon McVittie 2013-04-03 16:04:40 UTC 
Created attachment 240496 [details] [review]
Compile tp-lowlevel.vapi before  libfolks_telepathy_la_vala.stamp

The make rules generated by Automake are all done in terms of a "stamp"
file in the $(srcdir), so if we want to give it more dependencies,
we need to do the same. This fixes a clean out-of-tree build.
Comment 2 Simon McVittie 2013-04-03 16:05:01 UTC 
Created attachment 240497 [details] [review]
libtpf-test.la: explicitly depend on telepathy-glib

This gets telepathy-glib into the generated .deps file, so that
Telepathy tests can find the TelepathyGLib namespace.
Comment 3 Simon McVittie 2013-04-03 17:50:08 UTC 
Created attachment 240521 [details] [review]
contactlist: copy .deps to the same place as .vapi if  necessary

valac specifically expects to find them in the same place: it's not
enough to have them both in the search path.

---

Actually, I think this is the root cause of the bug worked around by Attachment #240497 [details].
Comment 4 Philip Withnall 2013-04-03 19:40:01 UTC 
Review of attachment 240496 [details] [review]:

++
Comment 5 Philip Withnall 2013-04-03 19:43:43 UTC 
Review of attachment 240521 [details] [review]:

Fun.