After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697050 - gnome-getting-started broken (and is launched by gnome-initial-setup)
gnome-getting-started broken (and is launched by gnome-initial-setup)
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-01 15:13 UTC by Colin Walters
Modified: 2013-04-05 19:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-build-Add-disable-welcome-tour.patch (2.66 KB, patch)
2013-04-03 22:01 UTC, Colin Walters 		accepted-commit_now Details | Review
new version which also disables player (3.13 KB, patch)
2013-04-04 16:20 UTC, Colin Walters 		reviewed Details | Review
0001-build-Add-disable-welcome-tour.patch (3.52 KB, patch)
2013-04-04 19:12 UTC, Colin Walters 		accepted-commit_now Details | Review
0001-welcome-tour-Don-t-do-anything-if-we-don-t-have-yelp.patch (934 bytes, patch)
2013-04-05 19:40 UTC, Colin Walters 		accepted-commit_now Details | Review

Description Colin Walters 2013-04-01 15:13:14 UTC 
/usr/libexec/gnome-welcome-tour: line 28: yelp: command not found

We don't have yelp because we don't have docbook.

Current workaround: Alt-F4

Real fixes:
* Add --disable-welcome-tour option to gnome-initial-setup
* Add docbook
Comment 1 Matthias Clasen 2013-04-01 18:26:10 UTC 
I would argue that not having yelp is whats broken; in any case, how about just checking if yelp is present in the script ?
Comment 2 Colin Walters 2013-04-03 22:01:15 UTC 
Created attachment 240551 [details] [review]
0001-build-Add-disable-welcome-tour.patch
Comment 3 Michael Wood 2013-04-04 15:10:08 UTC 
We also have have the case where yelp is installed but the getting started docs aren't so not much use checking for yelp. Maybe we could check for the existence of the getting-started docs.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-04-04 15:13:17 UTC 
Review of attachment 240551 [details] [review]:

OK.
Comment 5 Michael Wood 2013-04-04 15:19:39 UTC 
Should the initial-setup-player be added to the 'not built' if --disable-welcome-tour ?
Comment 6 Colin Walters 2013-04-04 16:20:09 UTC 
Created attachment 240636 [details] [review]
new version which also disables player

Yep; thanks for spotting that, Michael!
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-04-04 16:41:49 UTC 
Review of attachment 240636 [details] [review]:

::: configure.ac
@@ +115,3 @@
+AM_CONDITIONAL(ENABLE_WELCOME_TOUR, test x${enable_welcome_tour} = xyes)
+AS_IF([test x${enable_welcome_tour} = xyes], [
+  AC_DEFINE(ENABLE_WELCOME_TOUR, 1, [Define if welcome tour should be enabled])

You should probably put the PKG_CHECK_MODULES(PLAYER, ...) behind such a check as well.
Comment 8 Colin Walters 2013-04-04 19:12:33 UTC 
Created attachment 240654 [details] [review]
0001-build-Add-disable-welcome-tour.patch
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-04-05 18:32:11 UTC 
Review of attachment 240654 [details] [review]:

OK.
Comment 10 Colin Walters 2013-04-05 19:40:27 UTC 
Created attachment 240790 [details] [review]
0001-welcome-tour-Don-t-do-anything-if-we-don-t-have-yelp.patch
Comment 11 Matthias Clasen 2013-04-05 19:42:06 UTC 
Review of attachment 240790 [details] [review]:

looks good
Comment 12 Colin Walters 2013-04-05 19:43:50 UTC 
Ok, let's skip the build patch then.