After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697026 - font size is too small by default and don't match system font size
font size is too small by default and don't match system font size
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-01 10:52 UTC by Adam Dingle
Modified: 2013-04-02 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (78.10 KB, image/png)
2013-04-01 10:52 UTC, Adam Dingle 		  Details
Patch (4.36 KB, patch)
2013-04-02 09:30 UTC, Carlos Garcia Campos 		committed Details | Review

Description Adam Dingle 2013-04-01 10:52:03 UTC 
I'm using Devhelp built from git master on Ubuntu 13.04.  I have WebKitGTK 1.11.92.

When I start Devhelp, text is tiny and hard to read.  I have Preferences->Fonts->Use system fonts set to true, but text appears much smaller than in other GNOME applications.  I need to use the Larger Text menu item to make it big enough to read comfortably.

I'll attach a screenshot.
Comment 1 Adam Dingle 2013-04-01 10:52:43 UTC 
Created attachment 240296 [details]
screenshot
Comment 2 Carlos Garcia Campos 2013-04-01 11:13:22 UTC 
hmm, WebKit2 uses font sizes in pixels instead of points. I added functions to convert font sizes from pixels to points when ported devhelp to WebKit2, but it seems that code was lost during the GSettings migration. I'll look at it.
Comment 3 Carlos Garcia Campos 2013-04-02 09:30:02 UTC 
Created attachment 240367 [details] [review]
Patch
Comment 4 Aleksander Morgado 2013-04-02 09:57:40 UTC 
Review of attachment 240367 [details] [review]:

Looks good to me... but wasn't the issue found in Webkit 1.11.92 (i.e. not Webkit2)?

::: src/dh-util.c
@@ +262,3 @@
+dh_util_convert_font_size_to_pixels (GtkWidget *widget,
+                                     gdouble    font_size)
+{

I would remove the 'dh_util' prefix in the static method.
Comment 5 Carlos Garcia Campos 2013-04-02 11:00:15 UTC 
(In reply to comment #4)
> Review of attachment 240367 [details] [review]:
> 
> Looks good to me... but wasn't the issue found in Webkit 1.11.92 (i.e. not
> Webkit2)?

WebKit2 is built by default in 1.11.92, and used by default in devhelp since 3.7.x IIRC.

> ::: src/dh-util.c
> @@ +262,3 @@
> +dh_util_convert_font_size_to_pixels (GtkWidget *widget,
> +                                     gdouble    font_size)
> +{
> 
> I would remove the 'dh_util' prefix in the static method.

Ok.
Comment 6 Aleksander Morgado 2013-04-02 11:08:20 UTC 
(In reply to comment #5)
> (In reply to comment #4)
> > Review of attachment 240367 [details] [review] [details]:
> > 
> > Looks good to me... but wasn't the issue found in Webkit 1.11.92 (i.e. not
> > Webkit2)?
> 
> WebKit2 is built by default in 1.11.92, and used by default in devhelp since
> 3.7.x IIRC.
> 

Ah, ok.

> > ::: src/dh-util.c
> > @@ +262,3 @@
> > +dh_util_convert_font_size_to_pixels (GtkWidget *widget,
> > +                                     gdouble    font_size)
> > +{
> > 
> > I would remove the 'dh_util' prefix in the static method.
> 
> Ok.

Just merge it when you have it.
Comment 7 Carlos Garcia Campos 2013-04-02 15:18:30 UTC 
Comment on attachment 240367 [details] [review]
Patch

Pushed.