After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697003 - keybindings: Fix ungrabbing of keys
keybindings: Fix ungrabbing of keys
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-31 21:55 UTC by Rui Matos
Modified: 2013-04-10 08:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keybindings: Fix ungrabbing of keys (10.53 KB, patch)
2013-03-31 21:55 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-03-31 21:55:03 UTC 
I didn't bisect but this probably stopped working with the switch to XI2.
Comment 1 Rui Matos 2013-03-31 21:55:05 UTC 
Created attachment 240263 [details] [review]
keybindings: Fix ungrabbing of keys

XUngrabKey() doesn't work for XI2 grabs and XI2 doesn't provide API
with similar functionality. As such, we have to refactor the code a
bit to be able to call XIUngrabKeycode() for each key binding, then
reload keybindings and finally grab the new ones.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-03-31 23:19:57 UTC 
Review of attachment 240263 [details] [review]:

Makes sense to me.
Comment 3 Rui Matos 2013-04-10 08:59:33 UTC 
Attachment 240263 [details] pushed as c7dc692 - keybindings: Fix ungrabbing of keys