After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696982 - Use an .ui file for the city view
Use an .ui file for the city view
Status: RESOLVED FIXED
Product: gnome-weather
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Weather Maintainer(s)
GNOME Weather Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-31 17:14 UTC by Paolo Borelli
Modified: 2013-04-02 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use an .ui file for the city view (9.72 KB, patch)
2013-03-31 17:14 UTC, Paolo Borelli 		accepted-commit_now Details | Review
Also move the "Gd" widgets to the .ui file (3.88 KB, patch)
2013-03-31 17:15 UTC, Paolo Borelli 		reviewed Details | Review

Description Paolo Borelli 2013-03-31 17:14:55 UTC 
These patches move all the widgetry to the ui file leaving the code small and clean. I split it into two steps: an ui file done with glade and a second patch that added the Gd widgets manually.
Comment 1 Paolo Borelli 2013-03-31 17:14:58 UTC 
Created attachment 240222 [details] [review]
Use an .ui file for the city view
Comment 2 Paolo Borelli 2013-03-31 17:15:44 UTC 
Created attachment 240223 [details] [review]
Also move the "Gd" widgets to the .ui file
Comment 3 Giovanni Campagna 2013-04-02 15:28:42 UTC 
Review of attachment 240222 [details] [review]:

Looks good
Comment 4 Giovanni Campagna 2013-04-02 15:29:31 UTC 
Review of attachment 240223 [details] [review]:

Please squash this with the other one
Comment 5 Paolo Borelli 2013-04-02 16:57:16 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.