After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696929 - window-list: problem with fullscreen
window-list: problem with fullscreen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.8.1
Depends on:
Blocks:
 
 
Reported: 2013-03-30 21:45 UTC by Matthias Clasen
Modified: 2013-04-02 21:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (863.20 KB, image/png)
2013-03-30 21:47 UTC, Matthias Clasen 		  Details
WindowList: fix behavior on fullscreen (1.91 KB, patch)
2013-04-02 15:44 UTC, Giovanni Campagna 		reviewed Details | Review
WindowList: fix behavior on fullscreen (1.90 KB, patch)
2013-04-02 21:00 UTC, Giovanni Campagna 		committed Details | Review

Description Matthias Clasen 2013-03-30 21:45:46 UTC 
In 3.8.0, when fullscreening any app, I see a bar the size of the window-list at the bottom of the screen - it shows half of a message tray.
Comment 1 Matthias Clasen 2013-03-30 21:47:20 UTC 
Created attachment 240178 [details]
screenshot
Comment 2 Giovanni Campagna 2013-04-02 15:44:10 UTC 
Created attachment 240399 [details] [review]
WindowList: fix behavior on fullscreen

LayoutManager will take care of our visibility, but we need to
adjust the message tray anchor point manually. Also, we must not
show ourselves when coming out of the overview if we're in fullscreen.
Comment 3 Florian Müllner 2013-04-02 15:55:15 UTC 
Review of attachment 240399 [details] [review]:

One comment, otherwise looks good!

::: extensions/window-list/extension.js
@@ +431,3 @@
 
+        this._fullscreenChangedId =
+            Main.layoutManager.connect('fullscreen-changed', Lang.bind(this, function() {

global.screen.connect('in-fullscreen-changed', ...) should be more future-proof.
Comment 4 Giovanni Campagna 2013-04-02 21:00:12 UTC 
Created attachment 240437 [details] [review]
WindowList: fix behavior on fullscreen

LayoutManager will take care of our visibility, but we need to
adjust the message tray anchor point manually. Also, we must not
show ourselves when coming out of the overview if we're in fullscreen.
Comment 5 Florian Müllner 2013-04-02 21:02:59 UTC 
Review of attachment 240437 [details] [review]:

Yup, thanks!
Comment 6 Giovanni Campagna 2013-04-02 21:06:30 UTC 
Attachment 240437 [details] pushed as d212a2f - WindowList: fix behavior on fullscreen