After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696889 - hidden lang files should not be presented to the user
hidden lang files should not be presented to the user
Status: RESOLVED INCOMPLETE
Product: gedit
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-30 03:05 UTC by José Aliste
Modified: 2015-04-27 11:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixing the issue (1.06 KB, patch)
2013-03-30 03:05 UTC, José Aliste 		committed Details | Review

Description José Aliste 2013-03-30 03:05:54 UTC 
Created attachment 240152 [details] [review]
patch fixing the issue

In gtksouceview some highlighting languages have the hidden property set to True. This means that these lang files should not be available to the user for him/her to chose the lang in any UI... So we should just hide languages that have the hidden flag.
Comment 1 Paolo Borelli 2013-04-04 20:39:01 UTC 
Review of attachment 240152 [details] [review]:

The patch looks good to me.

As discussed on irc please push both this and the assertion removal in gsv

::: gedit/gedit-window.c
@@ +1025,3 @@
 		lang = gtk_source_language_manager_get_language	(lm, ids[i]);
+
+		if (gtk_source_language_get_hidden (lang))

well, if I really want to nitpick here you could just do

if (!hidden)
    prepend()

and save a line
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-04-05 20:13:40 UTC 
Pushed a slightly modified version of the patch.
Comment 3 Ignacio Casal Quinteiro (nacho) 2013-04-05 20:17:50 UTC 
Reopening as there is a patch about an assertion not committed, although not sure about the patch. José mind to push that when you have time?
Comment 4 Sébastien Wilmet 2015-02-06 15:58:13 UTC 
(In reply to comment #1)
> As discussed on irc please push both this and the assertion removal in gsv

(In reply to comment #3)
> Reopening as there is a patch about an assertion not committed, although not
> sure about the patch. José mind to push that when you have time?


Is the GtkSourceView patch pushed? If it works in gedit I think so.
Comment 5 Sébastien Wilmet 2015-04-27 11:14:51 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment.
Thanks!