After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696791 - wayland: Queue a redraw after showing the stage
wayland: Queue a redraw after showing the stage
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-28 15:54 UTC by Neil Roberts
Modified: 2013-03-28 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wayland: Queue a redraw after showing the stage (2.70 KB, patch)
2013-03-28 15:54 UTC, Neil Roberts
accepted-commit_now Details | Review

Description Neil Roberts 2013-03-28 15:54:34 UTC
On the other backends we will get some sort of expose event after
showing the stage's window which will queue a redraw. These expose
events don't exist on Wayland so nothing will cause Clutter to queue a
redraw. Weston doesn't bother displaying anything for the stage's
surface until the first buffer is sent, which of course it will never
receive if Clutter doesn't paint anything. This patch just makes it
explicitly queue a redraw after the stage is shown so that we will
always pass at least one frame to the compositor.

The bug can be seen by running test-stage-sizing. That example doesn't
have any animations so it won't try to queue any redraws until
something interacts with it. On the other hand something like
test-actors works fine without the patch because it constantly queues
redraws anyway in order to display the animation.
Comment 1 Neil Roberts 2013-03-28 15:54:37 UTC
Created attachment 240065 [details] [review]
wayland: Queue a redraw after showing the stage
Comment 2 Emmanuele Bassi (:ebassi) 2013-03-28 16:07:52 UTC
Review of attachment 240065 [details] [review]:

makes sense.
Comment 3 Neil Roberts 2013-03-28 16:37:58 UTC
Ok, thanks. I've pushed it to master and the clutter-1.14 branch.

https://git.gnome.org/browse/clutter/commit/?id=d5896d284ee
https://git.gnome.org/browse/clutter/commit/?id=3e6f32f6d07