After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696720 - StIcon: use g_signal_connect_object() for safety
StIcon: use g_signal_connect_object() for safety
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-27 16:56 UTC by Giovanni Campagna
Modified: 2013-05-30 17:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
StIcon: use g_signal_connect_object() for safety (1.52 KB, patch)
2013-03-27 16:56 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-03-27 16:56:48 UTC 
I've seen the shell crash at least once in StIcon.
While I suspect unrelated memory corruption, this looks useful anyway.
Comment 1 Giovanni Campagna 2013-03-27 16:56:51 UTC 
Created attachment 239975 [details] [review]
StIcon: use g_signal_connect_object() for safety

Prevent a crash in case an icon is destroyed before the texture
finishes loading, and something else is keeping the texture alive
for any reason.
Comment 2 drago01 2013-03-28 22:55:35 UTC 
https://bugzilla.gnome.org/show_bug.cgi?id=694755#c5 related?
Comment 3 Giovanni Campagna 2013-03-28 23:00:08 UTC 
Yep, seems the same crash I got, although I wouldn't bet anything worth that this patch helps for real...
Comment 4 drago01 2013-04-28 15:18:45 UTC 
Review of attachment 239975 [details] [review]:

OK this seems to indeed "fix" bug 694755 , and even if it doesn't it does not hurt.

Seems like a candidate for the 3.8 branch as well.
Comment 5 Giovanni Campagna 2013-04-28 22:26:31 UTC 
Attachment 239975 [details] pushed as ef9c50e - StIcon: use g_signal_connect_object() for safety