After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696710 - HashSet.foreach((x) => { return true; }) should return true
HashSet.foreach((x) => { return true; }) should return true
Status: RESOLVED FIXED
Product: libgee
Classification: Platform
Component: general
0.10.x
Other Linux
: Normal normal
: ---
Assigned To: libgee-maint
libgee-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-27 15:52 UTC by Simon McVittie
Modified: 2013-03-31 15:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
HashSet.Iterator: return true from foreach() if we fall off the end (1.92 KB, patch)
2013-03-27 15:52 UTC, Simon McVittie 		committed Details | Review

Description Simon McVittie 2013-03-27 15:52:37 UTC 
Created attachment 239965 [details] [review]
HashSet.Iterator: return true from foreach() if we fall off  the end

This is documented to happen, and was implemented correctly in the other
collections, but not in HashSet.

---

The patch says it all, and includes a regression test.
Comment 1 Maciej (Matthew) Piechotka 2013-03-27 21:59:32 UTC 
Review of attachment 239965 [details] [review]:

Looks good. It should go to master, 0.10 and 0.8 branches.
Comment 2 Maciej (Matthew) Piechotka 2013-03-31 15:40:57 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.