After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696629 - fix sed(1) usage
fix sed(1) usage
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.36.x
Other OpenBSD
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-03-26 11:39 UTC by Antoine Jacoutot
Modified: 2013-04-07 07:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simpler match (991 bytes, patch)
2013-03-26 11:39 UTC, Antoine Jacoutot 		accepted-commit_now Details | Review

Description Antoine Jacoutot 2013-03-26 11:39:00 UTC 
Created attachment 239856 [details] [review]
simpler match

Hi.

The regex to modify the python shebang in gtester-report does not match on non-GNU sed. So let's make the check more generic.
ok?
Comment 1 Antoine Jacoutot 2013-04-06 10:39:16 UTC 
Anyone? This is a pretty trivial fix...
Comment 2 Colin Walters 2013-04-06 13:40:09 UTC 
Review of attachment 239856 [details] [review]:

Looks simpler and safe enough to me.
Comment 3 Antoine Jacoutot 2013-04-07 07:12:06 UTC 
Thanks Colin, it's in: d474309