After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696585 - shellDBus: Fix SetActive(false) for ScreenSaver DBus API
shellDBus: Fix SetActive(false) for ScreenSaver DBus API
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-25 20:33 UTC by Colin Walters
Modified: 2013-03-29 14:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-shellDBus-Fix-SetActive-false-for-ScreenSaver-DBus-A.patch (898 bytes, patch)
2013-03-25 20:33 UTC, Colin Walters 		accepted-commit_after_freeze Details | Review

Description Colin Walters 2013-03-25 20:33:31 UTC 
Someone changed .unlock() to deactivate() for the obvious symmetry
with active(), but forgot to update it here.
---
 js/ui/shellDBus.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Comment 1 Colin Walters 2013-03-25 20:33:57 UTC 
Created attachment 239828 [details] [review]
0001-shellDBus-Fix-SetActive-false-for-ScreenSaver-DBus-A.patch
Comment 2 Giovanni Campagna 2013-03-25 20:37:16 UTC 
Review of attachment 239828 [details] [review]:

Obviously correct.
Comment 3 Florian Müllner 2013-03-25 20:37:28 UTC 
Review of attachment 239828 [details] [review]:

s/active()/activate()/ in the commit message, otherwise looks good.