After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696542 - tests: remove extra unref in test_setup_non_existing_stream
tests: remove extra unref in test_setup_non_existing_stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-25 09:54 UTC by David Svensson Fors
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove extra unref (867 bytes, patch)
2013-03-25 09:54 UTC, David Svensson Fors 		committed Details | Review

Description David Svensson Fors 2013-03-25 09:54:27 UTC 
Created attachment 239737 [details] [review]
Remove extra unref

In rtspserver unit tests, there is an extra server unref at the end of test_setup_non_existing_stream, which is not needed (anymore). The unref was added because, at the time of writing, the test didn't complete without it. The attached suggested patch removes the extra unref.

This method can be used for checking that the test completes with the patch:

GST_DEBUG=check:7 GST_CHECKS=test_setup_non_existing_stream make -C tests/check gst/rtspserver.check

At the end of the output, gstcheck prints "cleaning up tasks", which means that the test has completed. The server is unreffed in the fixture teardown instead.
Comment 1 Tim-Philipp Müller 2013-03-28 12:56:03 UTC 
Thanks, pushed:


commit d728d59a00bbe1084782b048baece2caddd63bfd
Author: David Svensson Fors <davidsf@axis.com>
Date:   Wed Mar 20 12:33:54 2013 +0100

    tests: remove extra unref in test_setup_non_existing_stream
    
    The unref is not needed anymore, teardown runs without it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=696542