After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696540 - Ring buffer released after parsing caps when setting caps
Ring buffer released after parsing caps when setting caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.0.5
Other Linux
: Normal normal
: 1.0.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-25 08:50 UTC by Paul HENRYS
Modified: 2013-04-15 06:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.30 KB, patch)
2013-03-25 08:50 UTC, Paul HENRYS 		committed Details | Review

Description Paul HENRYS 2013-03-25 08:50:42 UTC 
Created attachment 239735 [details] [review]
Patch

In gstaudiobasesrc.c when setting src caps in gst_audio_base_src_setcaps(), the ringbuffer is released after parsing the caps which sets some fields inside spec and by releasing the ringbuffer, these data are then lost. This does not happen the first time setting the caps has the ringbuffer is considered has already release but any other time, this will fail.
In the patch in attachment, I just moved releasing the ringbuffer before parsing the caps to avoid such issue.
Comment 1 Sebastian Dröge (slomo) 2013-03-25 09:16:26 UTC 
commit 78a8531c7539dda7c22ca4b9bbd238c9c337005f
Author: Paul HENRYS <visechelle@gmail.com>
Date:   Fri Mar 22 13:41:17 2013 +0100

    audiobasesrc: Fix ringbuffer handling when settings caps
    
    ringbuffer was released after setting values to its spec field
    in gst_audio_base_src_setcaps(). This led to failure in case
    gst_audio_base_src_setcaps() is called more than one time.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=696540