GNOME Bugzilla – Bug 696244
qtdemux: send GAP events for subtitles, handle subtitles with SBLT subtype
Last modified: 2013-03-23 11:38:15 UTC
1. qtdemux doesn't recognize SBLT subtype. SBLT is used by handbrake and subler and is recognized by quicktime player. 2. qtdemux should ignore empty subtitle buffers. Those can be send to end previous buffer, but gstreamer has duration set on it so another buffer is not really necessary. Also it doesn't handle empty buffers (len = 2) well which results in sending garbage as data. 3. qtdemux doesn't send GAP event for subtitle streams.
Created attachment 239432 [details] [review] Patch to recognize SBTL subtype
Created attachment 239433 [details] [review] Patch to ignore empty subtitle buffer
Created attachment 239434 [details] [review] Path to send GAP events
Looks fine, thanks for the patches! Pushed: commit 49d9050e9ac829b685d2e999b2805132d1c181f7 Author: Matej Knopp <matej.knopp@gmail.com> Date: Thu Mar 21 02:55:06 2013 +0100 qtdemux: send GAP events for subtitle streams https://bugzilla.gnome.org/show_bug.cgi?id=696244 commit 516a0b8acb423c16fd207ac2463c261f869f9f4f Author: Matej Knopp <matej.knopp@gmail.com> Date: Thu Mar 21 02:53:24 2013 +0100 qtdemux: ignore empty subtitle buffers https://bugzilla.gnome.org/show_bug.cgi?id=696244 commit f494635126b6a1ae5c240b70e0f7c58a2ba1c35e Author: Matej Knopp <matej.knopp@gmail.com> Date: Thu Mar 21 02:52:07 2013 +0100 qtdemux: recognize SBTL subtype for subtitles https://bugzilla.gnome.org/show_bug.cgi?id=696244 I'm not sure if I have a sample file for these though, any chance you could make one available somewhere or point me to one?
Created attachment 239605 [details] [review] Additional patch to make recognition of empty subtitles buffer more robust For possibly misbehaving streams that don't include text length.
I'll provide sample file tomorrow, or you can test #696437 :)