After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696235 - gnome-initial-setup no longer visible since b328fd7aed4455b6b7378480baa2d604806f0bea
gnome-initial-setup no longer visible since b328fd7aed4455b6b7378480baa2d6048...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-20 22:32 UTC by Colin Walters
Modified: 2013-03-25 22:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Restore visibility of windows in initial-setup mode (739 bytes, patch)
2013-03-20 22:37 UTC, Giovanni Campagna 		accepted-commit_now Details | Review
sessionMode: Show windows in initial-setup mode (666 bytes, patch)
2013-03-20 22:38 UTC, Jasper St. Pierre (not reading bugmail) 		rejected Details | Review

Description Colin Walters 2013-03-20 22:32:07 UTC 
See https://bugzilla.gnome.org/show_bug.cgi?id=695747

We need to show windows in initial-setup mode, since it is a window.
Comment 1 Giovanni Campagna 2013-03-20 22:37:25 UTC 
Created attachment 239421 [details] [review]
Restore visibility of windows in initial-setup mode

gnome-initial-setup runs a regular X window, so we need to show it.

The patch is pretty obvious, but needs a hard code freeze break.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-03-20 22:38:11 UTC 
Created attachment 239422 [details] [review]
sessionMode: Show windows in initial-setup mode
Comment 3 Florian Müllner 2013-03-20 22:39:07 UTC 
Review of attachment 239421 [details] [review]:

Yup.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-03-20 22:39:10 UTC 
Review of attachment 239421 [details] [review]:

Whoa, nice. I actually wrote the patch before Colin filed the bug, but yeah, this is correct.
Comment 5 Florian Müllner 2013-03-20 22:39:27 UTC 
Review of attachment 239422 [details] [review]:

Giovanni was a tad bit faster :-)
Comment 6 Giovanni Campagna 2013-03-20 22:42:47 UTC 
Oh, lol, I guess I should wait 5 minutes before writing obvious patches.
But now the question is: who gets to mail the release team?
Comment 7 Matthias Clasen 2013-03-21 03:56:35 UTC 
I proactively give my +1 for the release team here. Still need to ask for the second one
Comment 8 Colin Walters 2013-03-21 17:11:14 UTC 
2/2 from R/T