GNOME Bugzilla – Bug 696206
Wayland documentation is missing from gdk reference
Last modified: 2013-03-27 20:07:33 UTC
There is currently no documentation for gdk/gdkwayland.h included in the gdk reference
Created attachment 239364 [details] [review] [PATCH] docs: Add wayland documentation to Gdk reference docs/reference/gdk/gdk-docs.sgml | 1 + docs/reference/gdk/gdk3-sections.txt | 49 ++++++++++++++++++++++++++++++++++++ gdk/wayland/gdkdisplay-wayland.c | 34 +++++++++++++++++++++++++ 3 files changed, 84 insertions(+)
Created attachment 239365 [details] [review] [PATCH] docs: Add wayland documentation to Gdk reference docs/reference/gdk/gdk-docs.sgml | 1 + docs/reference/gdk/gdk3-sections.txt | 49 ++++++++++++++++++++++++++++++++++++ gdk/wayland/gdkdisplay-wayland.c | 34 +++++++++++++++++++++++++ 3 files changed, 84 insertions(+)
Review of attachment 239365 [details] [review]: looks okay to me. ::: docs/reference/gdk/gdk3-sections.txt @@ +1140,3 @@ +gdk_wayland_window_get_wl_shell_surface +gdk_wayland_window_get_wl_surface +gdk_wayland_window_set_custom_surface set_custom_surface() is part of bug 695861 so I guess we need to rework the sequence of patches, or land this patch after the one in that bug.
Created attachment 239494 [details] [review] [PATCH] docs: Add wayland documentation to Gdk reference docs/reference/gdk/gdk-docs.sgml | 1 + docs/reference/gdk/gdk3-sections.txt | 49 ++++++++++++++++++++++++++++++++++++ gdk/wayland/gdkdisplay-wayland.c | 34 +++++++++++++++++++++++++ 3 files changed, 84 insertions(+)
(In reply to comment #3) > set_custom_surface() is part of bug 695861 so I guess we need to rework the > sequence of patches, or land this patch after the one in that bug. Yes let us just wait for bug 695861
ok gdk_wayland_window_set_use_custom_surface is landed, can we commit that now?
Review of attachment 239494 [details] [review]: Sure, this looks good to me.
(In reply to comment #7) > Sure, this looks good to me. Ok, commited. Thanks