After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696206 - Wayland documentation is missing from gdk reference
Wayland documentation is missing from gdk reference
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 695861
Blocks:
 
 
Reported: 2013-03-20 15:44 UTC by Jan Arne Petersen
Modified: 2013-03-27 20:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] docs: Add wayland documentation to Gdk reference (4.33 KB, patch)
2013-03-20 15:45 UTC, Jan Arne Petersen
none Details | Review
[PATCH] docs: Add wayland documentation to Gdk reference (4.34 KB, patch)
2013-03-20 15:51 UTC, Jan Arne Petersen
reviewed Details | Review
[PATCH] docs: Add wayland documentation to Gdk reference (4.34 KB, patch)
2013-03-21 19:51 UTC, Jan Arne Petersen
accepted-commit_now Details | Review

Description Jan Arne Petersen 2013-03-20 15:44:45 UTC
There is currently no documentation for gdk/gdkwayland.h included in the gdk reference
Comment 1 Jan Arne Petersen 2013-03-20 15:45:08 UTC
Created attachment 239364 [details] [review]
[PATCH] docs: Add wayland documentation to Gdk reference

 docs/reference/gdk/gdk-docs.sgml     |  1 +
 docs/reference/gdk/gdk3-sections.txt | 49 ++++++++++++++++++++++++++++++++++++
 gdk/wayland/gdkdisplay-wayland.c     | 34 +++++++++++++++++++++++++
 3 files changed, 84 insertions(+)
Comment 2 Jan Arne Petersen 2013-03-20 15:51:04 UTC
Created attachment 239365 [details] [review]
[PATCH] docs: Add wayland documentation to Gdk reference

 docs/reference/gdk/gdk-docs.sgml     |  1 +
 docs/reference/gdk/gdk3-sections.txt | 49 ++++++++++++++++++++++++++++++++++++
 gdk/wayland/gdkdisplay-wayland.c     | 34 +++++++++++++++++++++++++
 3 files changed, 84 insertions(+)
Comment 3 Emmanuele Bassi (:ebassi) 2013-03-20 16:38:58 UTC
Review of attachment 239365 [details] [review]:

looks okay to me.

::: docs/reference/gdk/gdk3-sections.txt
@@ +1140,3 @@
+gdk_wayland_window_get_wl_shell_surface
+gdk_wayland_window_get_wl_surface
+gdk_wayland_window_set_custom_surface

set_custom_surface() is part of bug 695861 so I guess we need to rework the sequence of patches, or land this patch after the one in that bug.
Comment 4 Jan Arne Petersen 2013-03-21 19:51:40 UTC
Created attachment 239494 [details] [review]
[PATCH] docs: Add wayland documentation to Gdk reference

 docs/reference/gdk/gdk-docs.sgml     |  1 +
 docs/reference/gdk/gdk3-sections.txt | 49 ++++++++++++++++++++++++++++++++++++
 gdk/wayland/gdkdisplay-wayland.c     | 34 +++++++++++++++++++++++++
 3 files changed, 84 insertions(+)
Comment 5 Jan Arne Petersen 2013-03-21 19:52:49 UTC
(In reply to comment #3)
> set_custom_surface() is part of bug 695861 so I guess we need to rework the
> sequence of patches, or land this patch after the one in that bug.

Yes let us just wait for bug 695861
Comment 6 Jan Arne Petersen 2013-03-27 19:33:13 UTC
ok gdk_wayland_window_set_use_custom_surface is landed, can we commit that now?
Comment 7 Cosimo Cecchi 2013-03-27 19:37:57 UTC
Review of attachment 239494 [details] [review]:

Sure, this looks good to me.
Comment 8 Jan Arne Petersen 2013-03-27 20:07:33 UTC
(In reply to comment #7)
> Sure, this looks good to me.

Ok, commited. Thanks