After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696102 - Message Tray context menu has some weird behavior
Message Tray context menu has some weird behavior
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-18 20:49 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-03-18 21:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
grabHelper: Ensure we reset ignoreRelease when we drop our event handler (985 bytes, patch)
2013-03-18 20:49 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-03-18 20:49:11 UTC 
Steps:

  1. Open the message tray
  2. Open the context menu by right-clicking on the tray
  3. Drop the tray by clicking outside
  4. Open the tray again
  5. Try to open the context menu by right-clicking

Expected:
  The menu pops up on release.

Actual:
  It doesn't happen immediately. It shows up after long-press.

This is because of a rogue grab helper feature -- ignoreRelease
is designed to make sure that the next actor doesn't see the
release event that comes from the press event that dropped the
grab, but it can get messed up if we drop the grab, letting it
never see the release event.

Patch that fixes the issue attached.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-03-18 20:49:14 UTC 
Created attachment 239195 [details] [review]
grabHelper: Ensure we reset ignoreRelease when we drop our event handler

Since we drop our event handler, we won't see ever the release event
from the button press, so unset the flag so it doesn't muck with the
next time somebody takes a grab.
Comment 2 Giovanni Campagna 2013-03-18 21:21:32 UTC 
Review of attachment 239195 [details] [review]:

I guess it makes sense.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-03-18 21:40:16 UTC 
Attachment 239195 [details] pushed as aec0e75 - grabHelper: Ensure we reset ignoreRelease when we drop our event handler