Bug 696092 – Crash when fetching task items

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 696092 - Crash when fetching task items


Summary:	Crash when fetching task items


Status:	RESOLVED FIXED

Product:	evolution-ews
Classification:	Other
Component:	Calendar
Version:	3.7.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Evolution EWS maintainer(s)
QA Contact:	Evolution EWS maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2013-03-18 18:29 UTC by Milan Crha
Modified:	2013-04-29 11:55 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Bug #696092 - Crash when fetching task items? (1.16 KB, patch) 2013-03-19 10:28 UTC, Fabiano Fidêncio	none	Details \| Review
Bug #696092 - Crash when fetching task items? (1.81 KB, patch) 2013-03-19 10:42 UTC, Fabiano Fidêncio	committed	Details \| Review

Description Milan Crha 2013-03-18 18:29:46 UTC

I just get this crash when I added new items in Outlook:
See these suspicious variables:
        name = 0x7f6e60014503 "Body"
        value = 0x0

+ Trace 231658

Thread 3 (Thread 0x7f6e70ff9700 (LWP 6251))

#0 waitpid
from /lib64/libpthread.so.0
#1 g_spawn_sync
from /lib64/libglib-2.0.so.0
#2 g_spawn_command_line_sync
from /lib64/libglib-2.0.so.0
#3 run_bug_buddy
at gnome-segvhanlder.c line 240
#4 bugbuddy_segv_handle
at gnome-segvhanlder.c line 191
#5 <signal handler called>
#6 e_ews_item_set_from_soap_parameter
at e-ews-item.c line 1038
#7 e_ews_item_new_from_soap_parameter
at e-ews-item.c line 1146
#8 ews_handle_items_param
at e-ews-connection.c line 896
#9 get_items_response_cb
at e-ews-connection.c line 937
#10 ews_response_cb
at e-ews-connection.c line 583
#11 process_queue_item
at soup-session-async.c line 274
#12 run_queue
at soup-session-async.c line 310
#13 idle_run_queue
at soup-session-async.c line 343
#14 idle_run_queue
at soup-session-async.c line 328
#15 g_main_context_dispatch
from /lib64/libglib-2.0.so.0
#16 g_main_context_iterate.isra.24
from /lib64/libglib-2.0.so.0
#17 g_main_loop_run
from /lib64/libglib-2.0.so.0
#18 e_ews_soup_thread
at e-ews-connection.c line 1430
#19 g_thread_proxy
from /lib64/libglib-2.0.so.0
#20 start_thread
from /lib64/libpthread.so.0
#21 clone
from /lib64/libc.so.6

Comment 1 Milan Crha 2013-03-18 18:33:17 UTC

Oops, no:

# 6  0x00007f6e97bd3a96 in e_ews_item_set_from_soap_parameter (item=0x7f6e600018e0, param=0x7f6e6000bd30) at e-ews-item.c:1038
1038				priv->contact_fields->notes = e_soap_parameter_get_string_value (subparam);
(gdb) p priv
$1 = (EEwsItemPrivate *) 0x7f6e6000ab80
(gdb) p priv->contact_fields
$2 = (struct _EEwsContactFields *) 0x0

Comment 2 Fabiano Fidêncio 2013-03-19 10:28:36 UTC

Created attachment 239232 [details] [review]
Bug #696092 - Crash when fetching task items?

Check if the EwsItem is a contact before trying to write Body content into it

Comment 3 Fabiano Fidêncio 2013-03-19 10:42:59 UTC

Created attachment 239234 [details] [review]
Bug #696092 - Crash when fetching task items?

Comment 4 Milan Crha 2013-03-19 10:46:20 UTC

Review of attachment 239234 [details] [review]:

Looks fine, please commit either after freeze or better if/when release-team gives you a permission. Thanks.

Comment 5 Fabiano Fidêncio 2013-03-19 12:04:32 UTC

Pushed!
https://git.gnome.org/browse/evolution-ews/commit/?id=8cb638af5ea990a3c3aee25f2fa365446487e63c

Comment 6 Milan Crha 2013-04-29 11:41:09 UTC

Downstream bug report about the same from 3.8.1:
https://bugzilla.redhat.com/show_bug.cgi?id=957398

I thought this reached 3.8.x too.

Comment 7 Milan Crha 2013-04-29 11:55:00 UTC

(In reply to comment #6)
> Downstream bug report about the same from 3.8.1:

It's evolution 3.8.1, but evolution-ews is 3.8.0 in that downstream bug report.

> I thought this reached 3.8.x too.

So it reached it in 3.8.1+. I'm sorry for confusion.