I also meant to ask if the code used to generate the character details tab could be exposed. Maybe split that from gucharmap-charmap.c and make that TextView available as a separate widget?

Sorry for the noise but I didn't see any mailing list for the project so figured I would ask here before filing another issue.

(In reply to comment #0)
> Gucharmap.ChaptersModel.id_to_iter 
> 
>  - iter should be an out parameter

I added an annotation; can you check that this fixes the problem?

> cheader_filename = "Gucharmap-2.90.h"
> 
>  - should probably be cheader_filename = "gucharmap/gucharmap.h"

Should be fixed now on git master. 

> Gucharmap-2.90.vapi
> 
>  - should probably be gucharmap-2.90.vapi

Not sure we can change this now, wouldn't that be an ABI break?

Thanks for the quick response.

The cheader_filename issue is definitely fixed.

The id_to_iter is not. It's still not marked as an "out" parameter.


As far as an ABI break goes. That I have no clue. :-( 

But, unfortunately, I *think* that change is a must since that's what pkg-config lists.

Created attachment 239049 [details] [review]
Add doc to function

Sorry if the patch isn't proper, but those changes work here.

Comitted to master. I'll ask the vala guys about the vapi name.

Nevermind about the name change, not needed. My mistake.

However, can you please revert the changes to gucharmap_chapters_model_get_codepoint_list that TreeIter is now marked as an out parameter which it isn't.

Thanks again.

Right, reverted that bit. So it works fine now using git master? If so, I'll release that as 3.7.92.

Looks good here.

Renamed the vapi too on advice from #vala.