After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695783 - GtkApplication: Allow passing windows on non-X11 targets
GtkApplication: Allow passing windows on non-X11 targets
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-03-13 15:04 UTC by Bastien Nocera
Modified: 2013-03-14 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkApplication: Allow passing windows on non-X11 targets (1.10 KB, patch)
2013-03-13 15:04 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-03-13 15:04:47 UTC 
.
Comment 1 Bastien Nocera 2013-03-13 15:04:49 UTC 
Created attachment 238794 [details] [review]
GtkApplication: Allow passing windows on non-X11 targets

It's not the application's fault that we don't do anything
with the passed GtkWindow on non-X11, so don't try to get an XID
on non-X11.
Comment 2 Allison Karlitskaya (desrt) 2013-03-14 16:23:16 UTC 
Review of attachment 238794 [details] [review]:

::: gtk/gtkapplication.c
@@ +1436,1 @@
         xid = GDK_WINDOW_XID (gdkwindow);

why not just check the type of the gdkwindow directly?
Comment 3 Bastien Nocera 2013-03-14 16:48:01 UTC 
Committed with Ryan's changes to gtk-3-8 and master, thanks.

Attachment 238794 [details] pushed as fcc6f9a - GtkApplication: Allow passing windows on non-X11 targets