GNOME Bugzilla – Bug 695769
fails to build with giflib 5.0
Last modified: 2013-03-14 16:44:08 UTC
Giflib had minor API changes and tracker fails to build against it. A typical build failure looks like: [ 333s] tracker-extract-gif.c: In function 'read_metadata': [ 333s] tracker-extract-gif.c:103:4: warning: implicit declaration of function 'PrintGifError' [-Wimplicit-function-declaration] [ 333s] tracker-extract-gif.c:141:8: warning: pointer targets in passing argument 1 of 'strlen' differ in signedness [-Wpointer-sign] [ 333s] In file included from tracker-extract-gif.c:29:0: [ 333s] /usr/include/string.h:395:15: note: expected 'const char *' but argument is of type 'GifByteType *' [ 333s] tracker-extract-gif.c:141:8: warning: pointer targets in passing argument 1 of 'strlen' differ in signedness [-Wpointer-sign] [ 333s] In file included from tracker-extract-gif.c:29:0: [ 333s] /usr/include/string.h:395:15: note: expected 'const char *' but argument is of type 'GifByteType *' [ 333s] tracker-extract-gif.c:141:8: warning: pointer targets in passing argument 1 of '__builtin_strcmp' differ in signedness [-Wpointer-sign] [ 333s] tracker-extract-gif.c:141:8: note: expected 'const char *' but argument is of type 'GifByteType *' [ 333s] tracker-extract-gif.c:141:8: warning: pointer targets in passing argument 1 of 'strlen' differ in signedness [-Wpointer-sign] [ 333s] In file included from tracker-extract-gif.c:29:0: [ 333s] /usr/include/string.h:395:15: note: expected 'const char *' but argument is of type 'GifByteType *' [ 333s] tracker-extract-gif.c:141:8: warning: pointer targets in passing argument 1 of '__builtin_strcmp' differ in signedness [-Wpointer-sign] [ 333s] tracker-extract-gif.c:141:8: note: expected 'const char *' but argument is of type 'GifByteType *' [ 333s] tracker-extract-gif.c:141:8: warning: pointer targets in passing argument 1 of '__builtin_strcmp' differ in signedness [-Wpointer-sign] [ 333s] tracker-extract-gif.c:141:8: note: expected 'const char *' but argument is of type 'GifByteType *' [ 333s] tracker-extract-gif.c:141:8: warning: pointer targets in passing argument 1 of '__builtin_strcmp' differ in signedness [-Wpointer-sign] [ 333s] tracker-extract-gif.c:141:8: note: expected 'const char *' but argument is of type 'GifByteType *' [ 333s] tracker-extract-gif.c:141:8: warning: pointer targets in passing argument 1 of 'strncmp' differ in signedness [-Wpointer-sign] [ 333s] In file included from tracker-extract-gif.c:29:0: [ 333s] /usr/include/string.h:143:12: note: expected 'const char *' but argument is of type 'GifByteType *' [ 333s] tracker-extract-gif.c:145:8: warning: pointer targets in passing argument 3 of 'ext_block_append' differ in signedness [-Wpointer-sign] [ 333s] tracker-extract-gif.c:63:1: note: expected 'unsigned char *' but argument is of type 'char *' [ 333s] tracker-extract-gif.c:172:6: warning: pointer targets in passing argument 3 of 'ext_block_append' differ in signedness [-Wpointer-sign] [ 333s] tracker-extract-gif.c:63:1: note: expected 'unsigned char *' but argument is of type 'char *' [ 333s] tracker-extract-gif.c: In function 'tracker_extract_get_metadata': [ 333s] tracker-extract-gif.c:620:2: error: too few arguments to function 'DGifOpenFileHandle' [ 333s] In file included from tracker-extract-gif.c:34:0: [ 333s] /usr/include/gif_lib.h:178:14: note: declared here [ 333s] make[4]: *** [libextract_gif_la-tracker-extract-gif.lo] Error 1 [ 333s] make[4]: *** Waiting for unfinished jobs.... [ 333s] tracker-extract-jpeg.c: In function 'tracker_extract_get_metadata': [ 333s] tracker-extract-jpeg.c:253:5: warning: pointer targets in passing argument 1 of 'iptc_jpeg_ps3_find_iptc' differ in signedness [-Wpointer-sign] [ 333s] In file included from tracker-extract-jpeg.c:53:0: [ 333s] /usr/include/libiptcdata/iptc-jpeg.h:32:5: note: expected 'const unsigned char *' but argument is of type 'gchar *' [ 333s] tracker-extract-jpeg.c:255:6: warning: pointer targets in passing argument 1 of 'tracker_iptc_new' differ in signedness [-Wpointer-sign] [ 333s] In file included from ../../src/libtracker-extract/tracker-extract.h:34:0, [ 333s] from tracker-extract-jpeg.c:33: [ 333s] ../../src/libtracker-extract/tracker-iptc.h:65:18: note: expected 'const guchar *' but argument is of type 'gchar *' [ 333s] make[4]: Leaving directory `/home/abuild/rpmbuild/BUILD/tracker-0.14.4/src/tracker-extract'
Created attachment 238775 [details] [review] And a possible fix for it
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report. Thanks Dominique. I've added to your patch a bit to give some more context - and fixed some style issues (not your fault, the file was written a looong time ago) :) Thanks again,