After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695758 - Ctrl+F/Ctrl+S don't focus the search entry
Ctrl+F/Ctrl+S don't focus the search entry
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on: 695917
Blocks:
 
 
Reported: 2013-03-13 11:27 UTC by Bastien Nocera
Modified: 2013-07-04 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Bastien Nocera 2013-03-13 11:27:01 UTC 
devhelp-3.7.91-1.fc19.x86_64

It used to.

1. Launch devhelp
2. Press "down" a couple of times to focus the list of books
3. Press Ctrl+F -> nothing, Ctrl+S -> nothing

Both should focus the search entry
Comment 1 Aleksander Morgado 2013-03-13 14:08:12 UTC 
Ctrl+F will open the search box to find text in the current page.

Ctrl+K is the combination used to focus the main search entry, kind of following the same logic as in web browsers, which use Ctrl+K to focus the search box.

I'll resolve it as NOTABUG for now.
Comment 2 Bastien Nocera 2013-03-13 16:43:45 UTC 
Ctrl+S used to work and doesn't anymore. Is there any reason why? That's my mechanical shortcut for devhelp.
Comment 3 Aleksander Morgado 2013-03-13 16:47:31 UTC 
(In reply to comment #2)
> Ctrl+S used to work and doesn't anymore. Is there any reason why? That's my
> mechanical shortcut for devhelp.

We decided to stick to Ctrl+K as that was the shortcut used everywhere else... Ctrl+S was kind of attached to 'Save' which we don't need.

Actually, I tried to add Ctrl+S to do the same thing as Ctrl+K but removed it as GApplication didn't allow two shortcuts for the same action at that time (not sure now).
Comment 4 Günther Wutz 2013-04-02 18:58:42 UTC 
There should be a Hint for this change. I didn't find any information for the Shortcuts in Devhelp (except the Page Shortcuts for printing or search in the actual tab). I think a Tooltip above the Search-Entry will make it.

Something like this
gtk_widget_set_tooltip_text(self->priv->entry, "Shortcut: CTRL-K");

Is a implementation of Mallard planned? Maybe i can help with this issue.
Comment 5 Marc-Andre Lureau 2013-04-10 20:08:04 UTC 
It would be better to revert the shortcut everybody is used to, before anther binding is added.
Comment 6 Olivier Crête 2013-06-21 23:04:36 UTC 
Can't just add a second action? focus-search-2 and set that to Ctrl-S, please
Comment 7 Aleksander Morgado 2013-07-04 12:36:47 UTC 
(In reply to comment #6)
> Can't just add a second action? focus-search-2 and set that to Ctrl-S, please

Yeah, did that, named 'focus-search-alt', which maps to Ctrl+S.

Pushed to git master.