After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695641 - Make the API docs a bit more complete and pretty
Make the API docs a bit more complete and pretty
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on: 676856
Blocks:
 
 
Reported: 2013-03-11 16:28 UTC by Tomeu Vizoso
Modified: 2013-03-14 23:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Improve a bit the look of the main page of the API docs (3.90 KB, patch)
2013-03-11 16:28 UTC, Tomeu Vizoso
committed Details | Review
Add overview and running sections to API docs (6.38 KB, patch)
2013-03-11 16:28 UTC, Tomeu Vizoso
committed Details | Review
Enable tests for the gtk-doc generation (812 bytes, patch)
2013-03-11 16:28 UTC, Tomeu Vizoso
committed Details | Review
Add a meaningful name and description to all sections/files in the API docs (16.06 KB, patch)
2013-03-11 16:28 UTC, Tomeu Vizoso
committed Details | Review

Description Tomeu Vizoso 2013-03-11 16:28:30 UTC
Not much meat yet, but should pave the way for more.
Comment 1 Tomeu Vizoso 2013-03-11 16:28:36 UTC
Created attachment 238597 [details] [review]
Improve a bit the look of the main page of the API docs
Comment 2 Tomeu Vizoso 2013-03-11 16:28:42 UTC
Created attachment 238598 [details] [review]
Add overview and running sections to API docs
Comment 3 Tomeu Vizoso 2013-03-11 16:28:49 UTC
Created attachment 238599 [details] [review]
Enable tests for the gtk-doc generation
Comment 4 Tomeu Vizoso 2013-03-11 16:28:53 UTC
Created attachment 238600 [details] [review]
Add a meaningful name and description to all sections/files in the API docs
Comment 5 Tomeu Vizoso 2013-03-12 07:50:05 UTC
This is the result, after applying these patches and those in bug 676856:

http://people.collabora.com/~tomeu/mutter-docs/
Comment 6 Colin Walters 2013-03-12 12:55:59 UTC
Review of attachment 238597 [details] [review]:

Looks good to me.
Comment 7 Colin Walters 2013-03-12 13:00:31 UTC
Review of attachment 238598 [details] [review]:

Minor comments:

::: doc/reference/mutter-overview.xml
@@ +7,3 @@
+    <para>Mutter is a GObject-based library for creating compositing window managers.</para>
+
+    <para>Compositors that wish to use Mutter must implement a subclass of #MetaPlugin and register it with meta_plugin_manager_set_plugin_type() before calling meta_init() but after g_type_init().</para>

There's no g_type_init() anymore...but it doesn't hurt too much to leave this in.

::: doc/reference/running-mutter.xml
@@ +84,3 @@
+          <term>MUTTER_WM_CLASS_FILTER</term>
+          <listitem>
+            <para>Comma-separated list of WM_CLASS names to which to restrict Mutter to.</para>

Phrasing is awkward here; how about:

Mutter will only manage windows whose WM_CLASS is in this comma-separated list.
Comment 8 Colin Walters 2013-03-12 13:00:59 UTC
Review of attachment 238599 [details] [review]:

Sure.
Comment 9 Colin Walters 2013-03-12 13:06:47 UTC
Review of attachment 238600 [details] [review]:

Nice improvement!
Comment 10 Tomeu Vizoso 2013-03-12 16:05:39 UTC
Thanks a lot for the reviews, I will push them with the suggested changes as soon as the ones in bug 676856 are reviewed.
Comment 11 Jasper St. Pierre (not reading bugmail) 2013-03-14 23:42:44 UTC
Attachment 238597 [details] pushed as 460dc9f - Improve a bit the look of the main page of the API docs
Attachment 238598 [details] pushed as 00a842f - Add overview and running sections to API docs
Attachment 238599 [details] pushed as 69c72eb - Enable tests for the gtk-doc generation
Attachment 238600 [details] pushed as 2efed44 - Add a meaningful name and description to all sections/files in the API docs