GNOME Bugzilla – Bug 695573
Untranslatable strings in glib-compile-schemas
Last modified: 2017-08-03 15:39:47 UTC
Created attachment 238530 [details] [review] Patch for the bug glib-compile-schemas has many untranslatable strings. For example: gio/glib-compile-schemas.c: 314 g_set_error (error, G_MARKUP_ERROR, 315 G_MARKUP_ERROR_INVALID_CONTENT, 316 "<%s> is not contained in " 317 "the specified range", tag); I've attached a patch. Please review it.
Created attachment 356789 [details] [review] glib-compile-schemas: Mark missing strings for translation Jiro’s patch, rebased to master, git-formatted, and with proper attribution.
Review of attachment 356789 [details] [review]: ++
Comment on attachment 356789 [details] [review] glib-compile-schemas: Mark missing strings for translation I’m going to push some follow-ups to improve the wording and drop trailing \n characters. Attachment 356789 [details] pushed as a7aa8ac - glib-compile-schemas: Mark missing strings for translation
The following fix has been pushed: c257757 glib-compile-schemas: Improve some translatable strings
Created attachment 356838 [details] [review] glib-compile-schemas: Improve some translatable strings • Fix capitalisation to be consistent • Use Unicode quotation marks where appropriate • Move trailing \n characters out of the translable strings and append them unconditionally Signed-off-by: Philip Withnall <withnall@endlessm.com>
This file doesn’t use Unicode yet for a reason, see bug #772221#c4 and <https://git.gnome.org/browse/glib/commit/?id=2d56c49b1085ae3ad769e6b59329cf493eb0f8a1>. (BTW, GLib consistently uses double quotation marks.)
Pushed some follow-ups to convert to double quotation marks, and to fix the failing gschema-compile unit test. The following fixes have been pushed: ad9d5a1 tests: Fix gschema-compile test for translatable string changes 25c01e1 glib-compile-schemas: Use double quotes rather than single quotes
Created attachment 356871 [details] [review] tests: Fix gschema-compile test for translatable string changes Little did I know when making commit c257757cf6774974cf15370ccf09fad7ee855668 that a lot of the output of glib-compile-schemas is string matched in some of the unit tests. Fix them to match the updated strings. Signed-off-by: Philip Withnall <withnall@endlessm.com>
Created attachment 356872 [details] [review] glib-compile-schemas: Use double quotes rather than single quotes It’s what GLib is standardising on. See bug #772221. Signed-off-by: Philip Withnall <withnall@endlessm.com>