After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695550 - does not compile without LONG_DOUBLE
does not compile without LONG_DOUBLE
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
0.10.x
Other OpenBSD
: Normal major
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-03-10 10:14 UTC by Antoine Jacoutot
Modified: 2013-03-10 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
reverse logic for GOFFICE_WITH_LONG_DOUBLE check (969 bytes, patch)
2013-03-10 10:14 UTC, Antoine Jacoutot 		none Details | Review

Description Antoine Jacoutot 2013-03-10 10:14:45 UTC 
Created attachment 238512 [details] [review]
reverse logic for GOFFICE_WITH_LONG_DOUBLE check

Hi.

When building goffice (0.10.1) with GOFFICE_WITH_LONG_DOUBLE undefined, it fails with:

cc -DHAVE_CONFIG_H -I. -I.. -I.. -pthread -I/usr/local/include/libgsf-1 -I/usr/local/include/librsvg-2.0 -I/usr/local/include/lasem-0.4 -I/usr/local/include/libxml2 -I/usr/local/include -I/usr/local/include/gtk-3.0 -I/usr/local/include/at-spi2-atk/2.0 -I/usr/local/include/gio-unix-2.0/ -I/usr/X11R6/include -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include/harfbuzz -I/usr/local/include/atk-1.0 -I/usr/X11R6/include/pixman-1 -I/usr/X11R6/include/freetype2 -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/libpng -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -DGOFFICE_COMPILATION -I/usr/local/include -O2 -pipe -Wall -Wall -Wmissing-prototypes -Wsign-compare -Wpointer-arith -Wchar-subscripts -Wwrite-strings -Wdeclaration-after-statement -Wnested-externs -Wmissing-noreturn -Werror=missing-prototypes -Werror=nested-externs -Werror=implicit-function-declaration -Wmissing-declarations -Wno-pointer-sign -Werror=format-security -Wstrict-prototypes -MT go-cspline.lo -MD -MP -MF .deps/go-cspline.Tpo -c math/go-cspline.c -fPIC -DPIC -o .libs/go-cspline.o
math/go-cspline.c:236: error: no previous prototype for 'go_csplinel_get_type'

Not sure I'm right here, but it seems there is a resersed logic check for GOFFICE_WITH_LONG_DOUBLE in goffice/math/go-cspline.h. The attached patch fixes the issue for me.

Thoughts?
Comment 1 Morten Welinder 2013-03-10 20:06:44 UTC 
The conditional is correct as it is.  Something else is up.
Comment 2 Morten Welinder 2013-03-10 20:20:09 UTC 
https://git.gnome.org/browse/goffice/commit/?id=01f93869b7e2e9b38bd62c94d9d71103dffa4f08

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

I am still seeing problems with introspection after this, but this is progress.