After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695417 - Wifi toggle in Power Saving panel is ambiguous
Wifi toggle in Power Saving panel is ambiguous
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Power
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
Control-Center Maintainers
: 707559 744635 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-03-08 01:16 UTC by Dylan McCall
Modified: 2015-08-03 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the Power settings panel with the Wi-Fi toggle visible (35.44 KB, image/png)
2013-03-08 01:18 UTC, Dylan McCall
  Details
power: ambiguous wifi and mobile broadband labels (1.87 KB, patch)
2014-06-24 22:43 UTC, Michael Catanzaro
committed Details | Review
power: ambiguous wi-fi and mobile broadband labels (2.02 KB, patch)
2014-06-24 22:48 UTC, Michael Catanzaro
rejected Details | Review
power: Improve labels for wifi and mobile broadband toggles (1.67 KB, patch)
2015-04-24 14:25 UTC, Michael Catanzaro
committed Details | Review

Description Dylan McCall 2013-03-08 01:16:37 UTC
The Power settings panel has a new Wi-Fi item under the heading "Power Saving." As well as the label "Wi-Fi", there is some added descriptive text that says "Turns off wireless devices." At first glance, I ended up with the misconception that this toggle was for some kind of Wi-Fi power saving feature.

I think the description really contributed to my error. Usually we let switch widgets speak for themselves, such that we can have a noun like Wi-Fi and an on/off switch and that plainly means "Turn Wi-Fi on or off." When I read the description, I had that same pattern in mind, so I interpreted it as "Turn the feature that turns Wi-Fi on or off." As I soon learned (after toggling the switch!), the description is redundant: this particular label says what clicking the switch widget is going to do. (And then only in the case that the switch is set to On).

I suspect this panel would be easier to understand if the extra description under "Wi-Fi" was simply removed.
Comment 1 Dylan McCall 2013-03-08 01:18:13 UTC
Created attachment 238350 [details]
Screenshot of the Power settings panel with the Wi-Fi toggle visible
Comment 2 Michael Catanzaro 2013-04-20 15:09:40 UTC
I don't think it's confusing at all, it's just wrong - the description is clear that the option is to turn off Wi-Fi, so if the option is turned on, Wi-Fi should be turned off.  That's the opposite of what it does.  Corrected text would read "Turns on wireless devices"

But I think we should just remove the description, since that's really obvious....
Comment 3 Michael Catanzaro 2013-04-20 15:14:26 UTC
I just noticed Bug #698419 is related
Comment 4 Michael Catanzaro 2014-06-24 22:43:10 UTC
Created attachment 279156 [details] [review]
power: ambiguous wifi and mobile broadband labels

Currently these switches function the opposite of their descriptions.
E.g. the wi-fi switch says "turns off wireless devices" which means that
if the switch is on, wi-fi would go off, but actually the behavior is
the opposite. Reword the labels to be less confusing.

Patch option #1 of 2, I'd favor just removing the descriptions since there are other things (Bluetooth) there that have no descriptions.
Comment 5 Michael Catanzaro 2014-06-24 22:48:05 UTC
Created attachment 279160 [details] [review]
power: ambiguous wi-fi and mobile broadband labels

Currently these switches function the opposite of their descriptions.
E.g. the wi-fi switch says "turns off wireless devices" which means that
if the switch is on, wi-fi would go off, but actually the behavior is
the opposite. Remove these labels: they are purely confusing, and the
behavior of the switches is clear without them.

Patch option #2
Comment 6 Michael Catanzaro 2015-02-03 19:59:39 UTC
Bastien, what do you think here? I think I prefer my option #2....
Comment 7 Bastien Nocera 2015-02-04 17:39:22 UTC
Review of attachment 279156 [details] [review]:

That seems like the better one of the two.
Comment 8 Bastien Nocera 2015-02-04 17:40:11 UTC
And if we decide to go with option #2 later, at least it's not a string change.
Comment 9 Michael Catanzaro 2015-02-04 19:23:18 UTC
OK, thanks.

Attachment 279156 [details] pushed as 643a7a6 - power: ambiguous wifi and mobile broadband labels
Comment 10 Piotr Drąg 2015-02-05 16:10:16 UTC
*** Bug 707559 has been marked as a duplicate of this bug. ***
Comment 11 Bastien Nocera 2015-02-17 09:55:35 UTC
*** Bug 744635 has been marked as a duplicate of this bug. ***
Comment 12 Ben Davis 2015-04-23 23:27:17 UTC
After seeing these two setttings:

* "Wireless devices require extra power"
* "Mobile broadband devices require extra power"

I still have no idea what they are supposed to do. What does it mean by "extra power"? Does that mean that wifi is disabled when my battery is low? Or does that mean wifi will be put into some power saving mode?
Comment 13 Michael Catanzaro 2015-04-24 01:06:28 UTC
I'm not sure what to do here....
Comment 14 Allan Day 2015-04-24 09:08:37 UTC
(In reply to Ben Davis from comment #12)
> After seeing these two setttings:
> 
> * "Wireless devices require extra power"
> * "Mobile broadband devices require extra power"
> 
> I still have no idea what they are supposed to do. What does it mean by
> "extra power"? Does that mean that wifi is disabled when my battery is low?
> Or does that mean wifi will be put into some power saving mode?

I agree that "extra" is confusing here - extra to what? These strings need to do two things - 

1. They need to clarify that the device will be disabled when the switch is off.
2. They need to explain that this will save power.

So you could go with something like "Turn off Wi-Fi to save power."
Comment 15 Michael Catanzaro 2015-04-24 14:25:40 UTC
Created attachment 302293 [details] [review]
power: Improve labels for wifi and mobile broadband toggles

OK, that's clearly a good choice, thanks. :)
Comment 16 Bastien Nocera 2015-08-03 15:40:20 UTC
I've also done s/WiMax/LTE/ in a subsequent patch.

Attachment 302293 [details] pushed as 7333e08 - power: Improve labels for wifi and mobile broadband toggles