After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695314 - Esc should close folders in app picker
Esc should close folders in app picker
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
3.7.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 695252 698171 700688 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-03-06 18:45 UTC by Mantas Mikulėnas (grawity)
Modified: 2013-05-20 06:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
appDisplay: Use GrabHelper for keynav and shortcuts (3.19 KB, patch)
2013-03-06 21:04 UTC, Florian Müllner 		needs-work Details | Review
appDisplay: Implement folder keynav and shortcuts (1.76 KB, patch)
2013-05-13 17:36 UTC, Florian Müllner 		committed Details | Review

Description Mantas Mikulėnas (grawity) 2013-03-06 18:45:53 UTC 
When a folder is open in the app picker, pressing Esc closes the entire app picker screen and returns to the window thumbnails. I expected it to only close the folder popup – i.e. the "topmost" layer.

(Minor thing, but I was advised to post this anyway.)
Comment 1 Florian Müllner 2013-03-06 21:04:33 UTC 
Created attachment 238245 [details] [review]
appDisplay: Use GrabHelper for keynav and shortcuts

While we cannot use grabHelper for dismissing folder popups by
clicks - we only want to intercapt clicks elsewhere in the app
picker, but not globally - we can leverage it for keynav and
closing by hitting Escape.
Comment 2 Florian Müllner 2013-03-06 21:05:25 UTC 
*** Bug 695252 has been marked as a duplicate of this bug. ***
Comment 3 Florian Müllner 2013-04-17 06:40:35 UTC 
*** Bug 698171 has been marked as a duplicate of this bug. ***
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-05-13 17:05:02 UTC 
Review of attachment 238245 [details] [review]:

I eventually want to remove grabFocus grabs. Having them on top of a modal grab is wrong, as it will get into a broken state if another window calls XSetInputFocus.
Comment 5 Florian Müllner 2013-05-13 17:36:42 UTC 
Created attachment 244078 [details] [review]
appDisplay: Implement folder keynav and shortcuts

Okay, let's do it manually then ...
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-05-13 17:39:51 UTC 
Review of attachment 244078 [details] [review]:

Much better.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-05-13 17:41:09 UTC 
Review of attachment 244078 [details] [review]:

Well, "unexptected", but that's it.
Comment 8 Florian Müllner 2013-05-13 17:43:43 UTC 
Attachment 244078 [details] pushed as b79b095 - appDisplay: Implement folder keynav and shortcuts
Comment 9 Florian Müllner 2013-05-20 06:30:45 UTC 
*** Bug 700688 has been marked as a duplicate of this bug. ***