After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695241 - Improvements for selection mode
Improvements for selection mode
Status: RESOLVED FIXED
Product: gnome-weather
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Weather Maintainer(s)
GNOME Weather Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-05 19:17 UTC by Cosimo Cecchi
Modified: 2013-03-05 22:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: improve selection mode style (4.12 KB, patch)
2013-03-05 19:17 UTC, Cosimo Cecchi
committed Details | Review
world: fix some bugs in iter delete code (1.08 KB, patch)
2013-03-05 19:17 UTC, Cosimo Cecchi
committed Details | Review
window: add a selection toolbar with a delete action (4.04 KB, patch)
2013-03-05 19:18 UTC, Cosimo Cecchi
committed Details | Review
Update to latest libgd (1.10 KB, patch)
2013-03-05 19:18 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2013-03-05 19:17:52 UTC
See attached patchset; selection mode now behaves like in other G3 applications.
Comment 1 Cosimo Cecchi 2013-03-05 19:17:53 UTC
Created attachment 238155 [details] [review]
window: improve selection mode style

- don't use a toggle button for selection mode
- add/remove the style class to the header
- add a descriptive text as title header
- hide the New button in selection mode
Comment 2 Cosimo Cecchi 2013-03-05 19:17:56 UTC
Created attachment 238156 [details] [review]
world: fix some bugs in iter delete code
Comment 3 Cosimo Cecchi 2013-03-05 19:18:00 UTC
Created attachment 238157 [details] [review]
window: add a selection toolbar with a delete action
Comment 4 Cosimo Cecchi 2013-03-05 19:18:02 UTC
Created attachment 238158 [details] [review]
Update to latest libgd

For a selection view fix.
Comment 5 Giovanni Campagna 2013-03-05 21:43:17 UTC
Review of attachment 238156 [details] [review]:

Asd, that code was clearly never tested.
Comment 6 Giovanni Campagna 2013-03-05 21:46:11 UTC
Review of attachment 238155 [details] [review]:

One minor nit.

::: src/window.js
@@ +112,3 @@
+            if (mode) {
+                this._header.get_style_context().add_class('selection-mode');
+        }));

On cities / on locations?
Comment 7 Giovanni Campagna 2013-03-05 21:51:03 UTC
Review of attachment 238157 [details] [review]:

Looks good, except for the previous comment on the header title.
Comment 8 Giovanni Campagna 2013-03-05 21:51:33 UTC
Review of attachment 238158 [details] [review]:

Sure.
Comment 9 Cosimo Cecchi 2013-03-05 22:22:33 UTC
Attachment 238155 [details] pushed as 274908c - window: improve selection mode style
Attachment 238156 [details] pushed as 7301d71 - world: fix some bugs in iter delete code
Attachment 238157 [details] pushed as f80c88e - window: add a selection toolbar with a delete action
Attachment 238158 [details] pushed as 8f991a3 - Update to latest libgd

Thanks, I changed it to "locations" and pushed these to gnome-3-8 and master.