GNOME Bugzilla – Bug 695241
Improvements for selection mode
Last modified: 2013-03-05 22:22:43 UTC
See attached patchset; selection mode now behaves like in other G3 applications.
Created attachment 238155 [details] [review] window: improve selection mode style - don't use a toggle button for selection mode - add/remove the style class to the header - add a descriptive text as title header - hide the New button in selection mode
Created attachment 238156 [details] [review] world: fix some bugs in iter delete code
Created attachment 238157 [details] [review] window: add a selection toolbar with a delete action
Created attachment 238158 [details] [review] Update to latest libgd For a selection view fix.
Review of attachment 238156 [details] [review]: Asd, that code was clearly never tested.
Review of attachment 238155 [details] [review]: One minor nit. ::: src/window.js @@ +112,3 @@ + if (mode) { + this._header.get_style_context().add_class('selection-mode'); + })); On cities / on locations?
Review of attachment 238157 [details] [review]: Looks good, except for the previous comment on the header title.
Review of attachment 238158 [details] [review]: Sure.
Attachment 238155 [details] pushed as 274908c - window: improve selection mode style Attachment 238156 [details] pushed as 7301d71 - world: fix some bugs in iter delete code Attachment 238157 [details] pushed as f80c88e - window: add a selection toolbar with a delete action Attachment 238158 [details] pushed as 8f991a3 - Update to latest libgd Thanks, I changed it to "locations" and pushed these to gnome-3-8 and master.