GNOME Bugzilla – Bug 695154
Pressing enter is broken in the unlock dialog
Last modified: 2013-05-08 00:01:23 UTC
I suspect 7b705dd6703973880472c741ad127c5684b1b036 "modalDialog: Fix auto-completion of prompts immediately upon display", because the press event is on the entry, not the dialog. I can connect to clutter_text.activate, but it looks wrong to me.
I can confirm this bug: In the current gnome-ostree, enter doesn't work in the GDM login entries either.
Thats blocker-worthy
Created attachment 238089 [details] [review] unlockDialog, loginDialog: Connect to the activate signal on the entry This is the recommended way to connect to an entry's activation binding -- event bubbling is not guaranteed by ClutterText. gdm changes untested -- unlock dialog changes tested, and they work.
(In reply to comment #0) > I suspect 7b705dd6703973880472c741ad127c5684b1b036 "modalDialog: Fix > auto-completion of prompts immediately upon display" For those following along at home, this was bug #692937.
Review of attachment 238089 [details] [review]: Looks good to me (and works fine)
In 3.6.3, with the rebased patch from bug 692937, i haven't seen the lock screen button affected, but the gdm button stopped registering <Enter> indeed. Does that seem possible? If so (and I am interested in doing the rebase), would it be okay for a rebase of this patch here for version 3.6.3 to just include the gdm fix or we should have both fixes anyway? Thanks!
Attachment 238089 [details] pushed as 1566a4e - unlockDialog, loginDialog: Connect to the activate signal on the entry
Confirmed fixed in current gnome-ostree builds.
*** Bug 695439 has been marked as a duplicate of this bug. ***
*** Bug 695568 has been marked as a duplicate of this bug. ***
*** Bug 695608 has been marked as a duplicate of this bug. ***
Hi! Would it be possible to have a patch to fix this for the gnome-shell 3-6 branch, please? As I said in c6, this affects the gdm greeter on gnome-shell 3.6.3, but not the unlock screen (at least with my testing). Thanks!
Hi! Very sorry for commenting on a RESOLVED bug, but enter key being broken in the gdm greeter by the patch in bug 692937 prevents a fix for bug 692937 being released for openSUSE 12.3 (which was released with GNOME 3.6 and is supported at least until Nov this year). Would be extremely grateful if somebody takes a look at this problem for 3.6.x as well. Thanks a lot.
(In reply to comment #13) > Would be extremely grateful if somebody takes a look at this problem > for 3.6.x as well. With 3.8 out of the door and 3.10 on its way, attaching a backported patch would be the best approach to getting someone to take a look :-)