After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694858 - open preferences for a specific extension doesn't work
open preferences for a specific extension doesn't work
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 690653 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-02-28 11:40 UTC by Matthias Clasen
Modified: 2013-02-28 14:48 UTC
See Also:
GNOME target: 3.8
GNOME version: ---

Attachments
extensionUtil: Add ExtensionFinder::extensions-loaded signal (1.35 KB, patch)
2013-02-28 13:58 UTC, Florian Müllner 		committed Details | Review
extensionPrefs: Fix opening extension preferences on startup (2.40 KB, patch)
2013-02-28 13:58 UTC, Florian Müllner 		committed Details | Review

Description Matthias Clasen 2013-02-28 11:40:08 UTC 
I tried to bring up the preferences of system-monitor@paradoxxx.zero.gmail.com, but it opens the preferences window without any extension selected in the combobox. I tried from both tweak tool and from the extension itself.
Comment 1 Florian Müllner 2013-02-28 13:58:01 UTC 
Created attachment 237597 [details] [review]
extensionUtil: Add ExtensionFinder::extensions-loaded signal

Consumers might want to defer work until the initial loading of
extensions has finished, so add an appropriate signal.
Comment 2 Florian Müllner 2013-02-28 13:58:07 UTC 
Created attachment 237598 [details] [review]
extensionPrefs: Fix opening extension preferences on startup

gnome-shell-extension-prefs supports opening a specific extension's
preferences directly from the command line by passing the UUID.
However this broke when extension loading was changed to be processed
asynchronously, as no extension has been loaded when the command
line argument is processed. Fix by deferring opening the extension's
preferences until all extensions have been loaded.
Comment 3 Florian Müllner 2013-02-28 14:01:40 UTC 
The issue has already been reported as bug 690653, but I'm not a fan of the attached patch there, so I'm attaching an alternative approach here ...
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-02-28 14:35:08 UTC 
Review of attachment 237598 [details] [review]:

OK.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-02-28 14:36:15 UTC 
Review of attachment 237597 [details] [review]:

OK.
Comment 6 Florian Müllner 2013-02-28 14:38:33 UTC 
Attachment 237597 [details] pushed as e99d69b - extensionUtil: Add ExtensionFinder::extensions-loaded signal
Attachment 237598 [details] pushed as 6e89d2f - extensionPrefs: Fix opening extension preferences on startup
Comment 7 Florian Müllner 2013-02-28 14:48:45 UTC 
*** Bug 690653 has been marked as a duplicate of this bug. ***