After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694796 - use standard styling for the ibus candidate popups
use standard styling for the ibus candidate popups
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-27 12:10 UTC by Allan Day
Modified: 2013-03-04 17:20 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8

Attachments
initial patch (1.31 KB, patch)
2013-02-27 12:16 UTC, Allan Day 		committed Details | Review

Description Allan Day 2013-02-27 12:10:29 UTC 
The new candidate chooser popups look great, but there's a couple of issues with them:

 * the text is too small
 * there isn't enough contrast between text and background (this is something we've heard in early feedback)
 * they look inconsistent with our other popups

My suggestion would be to use the standard boxpointer styling here.
Comment 1 Allan Day 2013-02-27 12:16:52 UTC 
Created attachment 237517 [details] [review]
initial patch

This applies the standard style to ibus popups. It doesn't seem to affect the text size for some reason, though.
Comment 2 Rui Matos 2013-02-28 10:13:12 UTC 
(In reply to comment #1)
> This applies the standard style to ibus popups. It doesn't seem to affect the
> text size for some reason, though.

The text size should be the default, i.e. 11pt .

Anyway, this is fine if that's how you want it to look. Otherwise you can draw it and I'll make sure it matches :-)
Comment 3 Rui Matos 2013-03-01 09:48:48 UTC 
Review of attachment 237517 [details] [review]:

looks good