After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694723 - Get rid of REBUILD stuff in configure.ac
Get rid of REBUILD stuff in configure.ac
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-02-26 03:59 UTC by Behdad Esfahbod
Modified: 2017-11-17 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Drop --enable-rebuilds configure option (3.06 KB, patch)
2017-11-17 13:54 UTC, Philip Withnall
committed Details | Review

Description Behdad Esfahbod 2013-02-26 03:59:41 UTC
It's a hack.  Should be replaced with "missing" calls in Makefile's.  I'll get to fix this eventually.
Comment 1 Philip Withnall 2017-11-17 13:54:45 UTC
Created attachment 363929 [details] [review]
build: Drop --enable-rebuilds configure option

It is outdated and no longer effectively used. It was originally in
place to prevent rebuilding generated files (from a tarball) if the
right build tools (awk, Perl, indent) were not available. However, we no
longer use indent, we have hard-required awk for a while, and the only
places the @REBUILD@ substitution was still used were for
glib-genmarshal, which has recently been rewritten in Python (so no
longer depends on whether Perl is available).

Drop the whole lot.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Emmanuele Bassi (:ebassi) 2017-11-17 14:22:25 UTC
Review of attachment 363929 [details] [review]:

I thought I got rid of all this cruft for the Meson build merge, but apparently something survived.

Yes to nuking from orbit. It's the only way to be sure.
Comment 3 Philip Withnall 2017-11-17 15:13:01 UTC
(In reply to Emmanuele Bassi (:ebassi) from comment #2)
> I thought I got rid of all this cruft for the Meson build merge, but
> apparently something survived.

Apparently Behdad spotted your omission 4.5 years ago, so all’s well.

Attachment 363929 [details] pushed as f2c093f - build: Drop --enable-rebuilds configure option