After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694443 - libgstaudio: add support for AAC pass-through
libgstaudio: add support for AAC pass-through
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 694445
 
 
Reported: 2013-02-22 12:32 UTC by Akihiro Tsukada
Modified: 2013-08-21 19:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libgstaudio: add support fo AAC passthrough (3.67 KB, patch)
2013-02-22 12:32 UTC, Akihiro Tsukada 		committed Details | Review

Description Akihiro Tsukada 2013-02-22 12:32:02 UTC 
Created attachment 237174 [details] [review]
libgstaudio: add support fo AAC passthrough

Some S/PDIF receivers have AAC hardware decoders,
and it would be nice if we could use AAC pass through just like AC3, DTS, etc.
The attached patch adds AAC to the iec61937 payloading of libgstaudio,
and I'm making another patch for pulsesink that uses this feature.
Comment 1 Tim-Philipp Müller 2013-02-25 16:12:23 UTC 
Looks fine.

Are we just going to ignore the 960-samples-per-frame variant because it's not very common, or is that according to the spec?
Comment 2 Akihiro Tsukada 2013-02-26 03:29:15 UTC 
I just read MPEG2 spec and refered to the source codes of FFmpeg
because I don't have the AAC payloading spec IEC61937-6,
so I didn't notice AAC-960.

I guess the spec allows the 960 variant,
but supporting it is difficult because of (my) lack of the necessary info
and ADTS frame header lacking in the information on samples per frame.
Should I drop MPEG4 related codes from the patch?

Currently, my decoder accepts and plays some samples of MPEG4 AAC 1024 samples per frame variant,
but not many cases are tested.
Comment 3 Tim-Philipp Müller 2013-02-27 00:42:45 UTC 
I think it's fine as it is for now:

 commit a32877125f0f70d74554d10a7a909f5b4e72f8e1
 Author: Akihiro Tsukada <atsukada@users.sourceforge.net>
 Date:   Fri Feb 22 21:02:19 2013 +0900

    audio: add support for AAC pass-through
    
    https://bugzilla.gnome.org/show_bug.cgi?id=694443