After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694394 - ScreenShield: fix positioning of background with multimonitor
ScreenShield: fix positioning of background with multimonitor
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-21 22:36 UTC by Giovanni Campagna
Modified: 2013-02-25 13:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ScreenShield: fix positioning of background with multimonitor (4.65 KB, patch)
2013-02-21 22:36 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2013-02-21 22:36:35 UTC
Previously, we would create one StBin per monitor, but each was positioned
at 0,0 and sized as the screen, so they would overlap and draw the box shadows
on top of the other backgrounds.
Instead, we need to size appropriately the bin, and then we need to position
the actual MetaBacgroundActor at 0,0, so add a flag to BackgroundManager
for this.
Also, get rid of MetaBackgroundGroup, they do nothing because the screenshield
is not a descendant of the MetaWindowGroup and because the widget in between
blocks the propagation of the visible region. At the same time, use a
widget, not a bin, because StBin requires you to set .child, not call add_child().
Comment 1 Giovanni Campagna 2013-02-21 22:36:38 UTC
Created attachment 237120 [details] [review]
ScreenShield: fix positioning of background with multimonitor
Comment 2 Ray Strode [halfline] 2013-02-25 05:01:17 UTC
Review of attachment 237120 [details] [review]:

ok
Comment 3 Giovanni Campagna 2013-02-25 13:47:52 UTC
Attachment 237120 [details] pushed as d5e647a - ScreenShield: fix positioning of background with multimonitor