GNOME Bugzilla – Bug 694347
Port to obexd as available in BlueZ 5.x
Last modified: 2013-11-09 14:18:31 UTC
Rather than relying on the unmaintained obex-data-server.
I'm working on this, will have a branch soon
Created attachment 244000 [details] [review] Bluetooth: remove old obex-data-server support This will be reimplemented as an obexd agent.
Created attachment 244001 [details] [review] Implement obexd agent
Created attachment 244002 [details] [review] Register the agent with the AgentManager
Created attachment 244003 [details] [review] Reimplement accepting files We have regressed support for ACCEPT_BONDED.
Created attachment 244004 [details] [review] obexd: notify the user when a transfer is completed
Created attachment 244005 [details] [review] obexd: implement asking the user to accept transfers And ask the user when the preference is 'bond' for now.
Created attachment 244006 [details] [review] Bring back obex push enabled/disabled support We don't look at whether bluetoothd is enabled yet as the default adapter concept is gone in bluez 5.
I initially removed the old bluez support and later on merged the bits that made sense. This made it easier to rewrite the agent as a GObject and to port to GDBus while at it. One thing that's still missing is 'paired' support. org.bluez.obex.Session1 should give us enough information to implement this I believe, but it doesn't seem to be working atm. So for now I implemented 'ask' (which wasn't implemented before the porting) and decided to fall back to 'ask' if the user has 'bonded'.
Created attachment 244074 [details] [review] Port to BlueZ 5
Created attachment 244075 [details] [review] obexd: implement asking the user to accept transfers And ask the user when the preference is 'bond' for now.
Created attachment 244076 [details] [review] Remove marshal generation The code that used this is gone.
New patches coming up fixing two issues: -only check changed_properties in transfer_property_changed() -fix return values for Release() and Cancel()
Created attachment 244299 [details] [review] Port to BlueZ 5
Created attachment 244300 [details] [review] obexd: implement asking the user to accept transfers And ask the user when the preference is 'bond' for now.
Created attachment 244301 [details] [review] Remove marshal generation The code that used this is gone.
(In reply to comment #9) > One thing that's still missing is 'paired' support. org.bluez.obex.Session1 > should give us enough information to implement this I believe, but it doesn't > seem to be working atm. So for now I implemented 'ask' (which wasn't > implemented before the porting) and decided to fall back to 'ask' if the user > has 'bonded'. Gustavo fixed this in bluez so this should be possible to implement now. I'll have a look at it, but probably not until next week.
Created attachment 246114 [details] [review] Implement auto-accept when bonded (In reply to comment #17) > (In reply to comment #9) > > One thing that's still missing is 'paired' support. org.bluez.obex.Session1 > > should give us enough information to implement this I believe, but it doesn't > > seem to be working atm. So for now I implemented 'ask' (which wasn't > > implemented before the porting) and decided to fall back to 'ask' if the user > > has 'bonded'. > > Gustavo fixed this in bluez so this should be possible to implement now. I'll > have a look at it, but probably not until next week. Done now.
So as mentioned on irc, we have regressed on FTP support. On the other hand, we now implement the 'ask' setting for the bluetooth-accept-files key. It would be trivial to make 'bonded' auto-accept when the device is paired and ask (instead of auto-reject) when the device is not paired, which is what gnome-user-share was doing before and so is what my patch that brings this back does too.
Leaving this opened as ObexFTP support isn't fixed, and obexd doesn't support disabling ObexPush for inactive sessions. Attachment 244299 [details] pushed as 8ac9a4d - Port to BlueZ 5 Attachment 244300 [details] pushed as 1f4a9bb - obexd: implement asking the user to accept transfers Attachment 244301 [details] pushed as 4de60bc - Remove marshal generation
Are the patches to bring back OBEX FTP somewhere? Even if we don't enable it by default, we still have a UI for it, so it seems a bit weird to have the UI and not the backend code (with all its caveats).
Never mind, I don't think we want to bring back ObexFTP, as we don't have any ObexFTP clients any more, and most phones don't include any ObexFTP clients (the ones that have OBEX support usually have Push, not FTP support). Closing.