GNOME Bugzilla – Bug 694284
AppDisplay's folder popup emits allocation warnings
Last modified: 2013-02-22 13:59:13 UTC
FolderPopup uses a ClutterConstraint to align itself horizontally, and we know those are broken if you constrain the actor on something whose least common ancestor is not the stage. It is possible to fix this by using Clutter align flags instead, but the downside is that the IconGrid then gets its natural size allocated, not the expanded one. It might be a minor problem, given that the folder popup has border and feels "closed" (so the outer whitespace is not relevant), but on the other hand you lose the horizontal alignment with the icons from all apps. Anyway, attaching the patch, then we can decide what to do.
Created attachment 236949 [details] [review] StScrollView: honor StBin fill and align properties StScrollView is a StBin, so it should honour [x,y]_fill and align on the child when overallocating it. Not relevant to this bug really, but I found it while trying another way, so I'm attaching it here. I'm fine with dropping it, if you feel it's not safe to change scrollview at this point.
Created attachment 236950 [details] [review] StScrollView: honor StBin fill and align properties StScrollView is a StBin, so it should honour [x,y]_fill and align on the child when overallocating it.
Review of attachment 236950 [details] [review]: OK.
Did you the see the warning in comment #0? This patch changes the appeareance of the popups, it can't go in as is.
Uh, I just noticed that this is not a regression from master behavior: popups are already smaller than the all app view. Pushing then.
Uh, but this wasn't the correct patch! This StScrollView change causes various regressions, because we implicitly assume x_fill: true around the shell, so I'm not pushing it now. It's 3.10 cleanup material. I'll attach the right one for this bug.
Created attachment 237059 [details] [review] AppDisplay: fix allocation loop warnings Don't use a constraint to position the boxpointer horizontally. Instead, use the right alignment flags and let the layout managers do their job.
Review of attachment 237059 [details] [review]: LGTM ::: js/ui/appDisplay.js @@ +613,3 @@ + // DOUBLE HACK: if you set one, you automatically + // get the effect for the other direction too, so + // we need to set the y_align Might make sense to split the comment and put the 1st paragraph above [xy]_expand and the 2nd one above [xy]_align.
Attachment 237059 [details] pushed as 95602eb - AppDisplay: fix allocation loop warnings Closing, the other one is a cleanup for another day.