After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694268 - Load HTTP auth protected pages doesn't work from the overview in WebKit2
Load HTTP auth protected pages doesn't work from the overview in WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2013-02-20 14:14 UTC by Carlos Garcia Campos
Modified: 2013-02-20 15:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.53 KB, patch)
2013-02-20 14:14 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2013-02-20 14:14:14 UTC 
Created attachment 236930 [details] [review]
Patch

The switch between overview and normal web page happens when the page load is committed, in case of HTTP auth protected pages we never switch to web page mode because authentication  happens before the load is committed. In WebKit2 the auth dialog is attached to the web view, so we need to show the web view before the load is committed to show the auth dialog.
Comment 1 Claudio Saavedra 2013-02-20 14:44:35 UTC 
Review of attachment 236930 [details] [review]:

I'm trying to remember if there was any particular reason to do this during 'committed' instead of 'start', but I don't think so, so this is probably safe to do.
Comment 2 Carlos Garcia Campos 2013-02-20 14:59:29 UTC 
The reason is that the ephy web view address is manually updated in the committed state, because we know it won't change. But in this case, since overview will never be redirected we can use the web view uri directly as soon as the load starts.