After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694219 - shell: don't prelight icons in the icon view
shell: don't prelight icons in the icon view
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-19 22:47 UTC by Giovanni Campagna
Modified: 2013-02-22 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
shell: don't prelight icons in the icon view (1.07 KB, patch)
2013-02-19 22:47 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2013-02-19 22:47:31 UTC
The follow-state property used to have no effect, because we used pixbufs
directly. It started to work when we switched to GIcons, but it looks
bad because the prelighted icons are too contrasted, so revert to the
previous behaviour.
Comment 1 Giovanni Campagna 2013-02-19 22:47:33 UTC
Created attachment 236847 [details] [review]
shell: don't prelight icons in the icon view
Comment 2 Bastien Nocera 2013-02-22 10:13:18 UTC
Review of attachment 236847 [details] [review]:

++
Comment 3 Giovanni Campagna 2013-02-22 13:43:08 UTC
Pushed to master and gnome-3-8

Attachment 236847 [details] pushed as 2f1ae7e - shell: don't prelight icons in the icon view