After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694123 - Entry menus don't restore focus correctly when hitting escape
Entry menus don't restore focus correctly when hitting escape
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-18 21:17 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-02-18 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shellEntry: Don't navigate forward before popping up the menu (1.24 KB, patch)
2013-02-18 21:17 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-02-18 21:17:08 UTC 
Steps:
  1. Open Looking Glass
  2. Hit the context menu key
  3. Hit escape

Expected:
  Text entry focused

Actual:
  Key focus is emptied

Attached patch fixes issue.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-02-18 21:17:10 UTC 
Created attachment 236664 [details] [review]
shellEntry: Don't navigate forward before popping up the menu

Doing it before the grab messes up the grab helper's tracking
of where the focus was before, leading to it not tracking the
saved focus correctly, meaning that when we pop the menu back
down with escape, it doesn't restore focus correctly.
Comment 2 drago01 2013-02-18 21:20:05 UTC 
Review of attachment 236664 [details] [review]:

Makes sense.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-02-18 21:34:30 UTC 
Attachment 236664 [details] pushed as 75589b4 - shellEntry: Don't navigate forward before popping up the menu