GNOME Bugzilla – Bug 694038
Fix hot-corner hover regression while in the message tray
Last modified: 2013-05-09 14:00:08 UTC
This isn't really a "regression" since it never worked properly in a stable version of the Shell, but it was designed behavior. See patches.
Created attachment 236476 [details] [review] grabHelper: Fix indentation
Created attachment 236477 [details] [review] grabHelper: Ignore actors that we've already added
Created attachment 236478 [details] [review] messageTray: Re-add the hotcorner when the panel is updated The activities button may come and go at any moment now that we have a dynamic panel. We need to re-check the activities button whenever the panel is updated.
Created attachment 236479 [details] [review] messageTray: Drop more special overview handling
Created attachment 236480 [details] [review] messageTray: Drop more special overview handling Fix broken graphics when you hit the hot corner while in the message tray in the overview.
Review of attachment 236476 [details] [review]: Sure.
Review of attachment 236477 [details] [review]: In what situation is it possible that we call addActor with the same actor twice?
Review of attachment 236478 [details] [review]: Isn't this still dependent on signal connection order? Are we guaranteed that MessageTray will connect after Panel? At the very least, a comment in Main is needed.
Review of attachment 236480 [details] [review]: ::: js/ui/messageTray.js @@ +2388,3 @@ if (this._desktopClone) this._desktopClone.destroy(); + let cloneSource = Main.overview.visible ? global.overlay_group : global.window_group; overviewVisible is used to become true at showing, so before Main.overview.visible if the overview is animating. I think you want visibleTarget here.
(In reply to comment #7) > Review of attachment 236477 [details] [review]: > > In what situation is it possible that we call addActor with the same actor > twice? Session mode is updated, and we'll re-add the activities button. (In reply to comment #8) > Review of attachment 236478 [details] [review]: > > Isn't this still dependent on signal connection order? Yes. Do you have any other suggestions on how to do these interdependencies? Add and connect to a 'panel-layout-changed' signal?
Created attachment 236563 [details] [review] messageTray: Re-add the hotcorner when the panel is updated The activities button may come and go at any moment now that we have a dynamic panel. We need to re-check the activities button whenever the panel is updated.
Created attachment 236564 [details] [review] messageTray: Drop more special overview handling
Created attachment 236565 [details] [review] messageTray: Jiggle some code around This is to put state management with state management
Created attachment 236566 [details] [review] messageTray: Don't allow opening while entering/leaving the overview The complex overview transition code means that there's no easy way to handle with this right now. Blocking the message tray while the overview is animating seems like the correct thing to do.
Created attachment 236567 [details] [review] messageTray: Re-add the hotcorner when the panel is updated The activities button may come and go at any moment now that we have a dynamic panel. We need to re-check the activities button whenever the panel is updated.
Comment on attachment 236476 [details] [review] grabHelper: Fix indentation Attachment 236476 [details] pushed as 6ffe3a4 - grabHelper: Fix indentation
Review of attachment 236564 [details] [review]: Yes (after IRC discussion)
Review of attachment 236565 [details] [review]: Maybe squash with the next one? (ACN if you don't want to)
Review of attachment 236566 [details] [review]: Yes.
Review of attachment 236567 [details] [review]: Ok
Attachment 236564 [details] pushed as f3901eb - messageTray: Drop more special overview handling Attachment 236565 [details] pushed as 4a3a61b - messageTray: Jiggle some code around Attachment 236566 [details] pushed as ee62863 - messageTray: Don't allow opening while entering/leaving the overview Attachment 236567 [details] pushed as b53d1df - messageTray: Re-add the hotcorner when the panel is updated