After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693970 - WindowOverlay: remove animations when relayouting
WindowOverlay: remove animations when relayouting
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-16 16:28 UTC by Giovanni Campagna
Modified: 2013-02-16 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
WindowOverlay: remove animations when relayouting (1.12 KB, patch)
2013-02-16 16:29 UTC, Giovanni Campagna 		reviewed Details | Review
WindowOverlay: remove animations when relayouting (1.36 KB, patch)
2013-02-16 17:06 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-02-16 16:28:59 UTC 
If WindowOverlay.relayout() is called without animation, we must stop
any preexisting animation, otherwise it will continue to run with the
previous parameters and cause the overlay to end up in the wrong position.
Comment 1 Giovanni Campagna 2013-02-16 16:29:03 UTC 
Created attachment 236376 [details] [review]
WindowOverlay: remove animations when relayouting
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-02-16 16:54:37 UTC 
Review of attachment 236376 [details] [review]:

It's probably worth it to run it unconditionally, as it will work in both cases, and make the code clearer.
Comment 3 Giovanni Campagna 2013-02-16 17:06:03 UTC 
Created attachment 236377 [details] [review]
WindowOverlay: remove animations when relayouting

If WindowOverlay.relayout() is called without animation, we must stop
any preexisting animation, otherwise it will continue to run with the
previous parameters and cause the overlay to end up in the wrong position.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-02-16 17:07:45 UTC 
Review of attachment 236377 [details] [review]:

Yes.
Comment 5 Giovanni Campagna 2013-02-16 18:08:45 UTC 
Attachment 236377 [details] pushed as 5c7f0a0 - WindowOverlay: remove animations when relayouting