After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693958 - Add PDF support
Add PDF support
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: Google Documents service
git master
Other Linux
: Normal normal
: ---
Assigned To: libgdata-maint
libgdata-maint
Depends on:
Blocks: 693957
 
 
Reported: 2013-02-16 14:04 UTC by William Jon McCann
Modified: 2013-02-16 16:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add support for PDF files (14.96 KB, patch)
2013-02-16 14:25 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2013-02-16 14:04:03 UTC 
The google docs api supports http://schemas.google.com/docs/2007#pdf type files. It would be great to have this support as well. So it can be used in Documents.
Comment 1 William Jon McCann 2013-02-16 14:25:24 UTC 
Created attachment 236364 [details] [review]
Add support for PDF files
Comment 2 Philip Withnall 2013-02-16 16:17:06 UTC 
Review of attachment 236364 [details] [review]:

This looks good, thanks for taking the time to put it together. Please fix the two minor issues below and commit to master!

::: gdata/services/documents/gdata-documents-pdf.c
@@ +26,3 @@
+ * @include: gdata/services/documents/gdata-documents-pdf.h
+ *
+ * #GDataDocumentsPdf is a subclass of #GDataDocumentsDocument to represent a pdf document from Google Documents.

s/pdf/PDF/

@@ +64,3 @@
+ * Return value: (transfer full): a new #GDataDocumentsPdf, or %NULL; unref with g_object_unref()
+ *
+ * Since: 0.13.1

s/0.13.1/0.13.3/
Comment 3 William Jon McCann 2013-02-16 16:20:22 UTC 
Attachment 236364 [details] pushed as 0fd7b76 - Add support for PDF files