GNOME Bugzilla – Bug 693866
NM-pptp needs to be ported to GtkGrid
Last modified: 2015-03-30 10:33:42 UTC
In the GNOME 3.7.x builds, NM-pptp (0.9.6.0) fails to build due to no longer existing GTK_TABLE. [ 127s] libtool: link: gcc -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -o nm-pptp-auth-dialog nm_pptp_auth_dialog-main.o nm_pptp_auth_dialog-vpn-password-dialog.o -lnm-util -lnm-glib -lnm-glib-vpn -ldbus-glib-1 -ldbus-1 -lgtk-3 -lgdk-3 -latk-1.0 -lgio-2.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo-gobject -lpango-1.0 -lcairo -lgobject-2.0 -lgnome-keyring -lglib-2.0 [ 128s] nm_pptp_auth_dialog-vpn-password-dialog.o: In function `add_row': [ 128s] /home/abuild/rpmbuild/BUILD/NetworkManager-pptp-0.9.6.0/auth-dialog/vpn-password-dialog.c:127: undefined reference to `GTK_TABLE' [ 128s] /home/abuild/rpmbuild/BUILD/NetworkManager-pptp-0.9.6.0/auth-dialog/vpn-password-dialog.c:128: undefined reference to `GTK_TABLE' [ 128s] nm_pptp_auth_dialog-vpn-password-dialog.o: In function `add_table_rows': [ 128s] /home/abuild/rpmbuild/BUILD/NetworkManager-pptp-0.9.6.0/auth-dialog/vpn-password-dialog.c:157: undefined reference to `GTK_TABLE' [ 128s] nm_pptp_auth_dialog-vpn-password-dialog.o: In function `vpn_password_dialog_new': [ 128s] /home/abuild/rpmbuild/BUILD/NetworkManager-pptp-0.9.6.0/auth-dialog/vpn-password-dialog.c:232: undefined reference to `GTK_TABLE' [ 128s] /home/abuild/rpmbuild/BUILD/NetworkManager-pptp-0.9.6.0/auth-dialog/vpn-password-dialog.c:233: undefined reference to `GTK_TABLE' [ 128s] collect2: error: ld returned 1 exit status [ 128s] make[2]: *** [nm-pptp-auth-dialog] Error 1 [ 128s] make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/NetworkManager-pptp-0.9.6.0/auth-dialog' [ 128s] make[1]: *** [all-recursive] Error 1 [ 128s] make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/NetworkManager-pptp-0.9.6.0' [ 128s] make: *** [all] Error 2 [ 128s] error: Bad exit status from /var/tmp/rpm-tmp.PwnoGL (%build)
GTK_TABLE still exists. If you are manually inserting GTK_DISABLE_DEPRECATED into your CFLAGS, then don't do that. That said, we *do* have to port everything over to GtkGrid at some point...
I do not inject GTK_DISABLE_DEPRECATED... NetworkManager-pptp takes care of that in two places: http://git.gnome.org/browse/network-manager-pptp/tree/auth-dialog/Makefile.am and http://git.gnome.org/browse/network-manager-pptp/tree/properties/Makefile.am Thanks for pointing in that direction.. this allows me at least to 'build' it again.. yet, as you stated yourself, the fact remains that it should be ported at one point.
ah... missed that. several other issues too... apparently no one has touched this code in a long time...
OK, so the problem is that GTK_DISABLE_DEPRECATED now (as of fairly recently) causes gtk.h to not include gtktable.h. Anyway, removing that fixes the build. I made a few other small build fixes and pushed it.
Ported UI to GtkGrid (and changed other deprecated widgets): jk/gtkgrid-bgo693866
*** Bug 746858 has been marked as a duplicate of this bug. ***
In the main dialog widget "NT Domain" is now cut off, but before it was shown entirely. Maybe a missing expand property on the label or something?
http://people.redhat.com/dcbw/pptp.png
The rest looks good.
(In reply to Dan Williams from comment #7) > In the main dialog widget "NT Domain" is now cut off, but before it was > shown entirely. Maybe a missing expand property on the label or something? It showed the whole label for me. But, there was a stray "<property name="ellipsize">end</property>". Thanks for catching that. Committed: 359ac13 properties: update .ui file to GTK 3.4+ (bgo #693866) - master 0e23978 properties: update .ui file to GTK 3.4+ (bgo #693866) - nm-1-0