GNOME Bugzilla – Bug 693854
Fix barrier pressure
Last modified: 2013-02-15 21:51:07 UTC
See patches. Cosimo spotted this today, so I decided to investigate.
Created attachment 236208 [details] [review] barrier: Add a time field to MetaBarrierEvent This was used in gnome-shell, but last-minute changes and multiple branch confusion on my part meant the field actually never got added.
Created attachment 236209 [details] [review] layout: Fix old event removal If we increment our index variable while looping, this means that firstNewEvent will be one higher than it should. With a length 1 array, all events will be removed, so this has a cascading effect that events will not be stored at all.
Created attachment 236210 [details] [review] layout: Remove _addBarrierEvent Moving it inline to when we get the event means that we can remove the duplicate call to _getDistanceAcrossBarrier. Just a cleanup patch due to last-minute algorithm changes. Not crucial, but simplifies the code a tiny bit.
Review of attachment 236208 [details] [review]: time needs to be guint32, since it's a server time, which are CARD32 in the protocol.
Review of attachment 236209 [details] [review]: Yes
Review of attachment 236210 [details] [review]: OK, sure.
Comment on attachment 236208 [details] [review] barrier: Add a time field to MetaBarrierEvent Attachment 236208 [details] pushed as e8b0c11 - barrier: Add a time field to MetaBarrierEvent Pushed with suggested change.
Attachment 236209 [details] pushed as 001bbd3 - layout: Fix old event removal Attachment 236210 [details] pushed as e3eb4a2 - layout: Remove _addBarrierEvent