GNOME Bugzilla – Bug 693847
Don't repeat the same key in all 4 corners of some keys
Last modified: 2021-07-05 12:33:55 UTC
On my system, there are a few keys where the modifier doesn't change the actual keycode of the keys. In these cases, we probably want to just show what the key is once, instead of 4 separate times, cluttering the key and not really adding any new information. To give you an example of what I mean, I have two images. First is what we do today, the second is what it should look like: http://imgur.com/BaSoDZp http://imgur.com/idrhOT5
Sorry, the second should look like http://imgur.com/4o1j2BI
Created attachment 236196 [details] [review] Remove-redundent-key-label-information.patch
also the related distro bug for this is https://bugs.launchpad.net/gnome-control-center/+bug/1025508
Hi, would someone please comment on the suitability of this patch?
Antonio, what do you think about this patch?
While James has a point about duplicated key labels not being pretty, I think that handling just the case of GKBD_KEYBOARD_DRAWING_POS_TOPLEFT like the current patch does is not general enough. Maybe some option to say "if _all_ key labels are the same just show one of them" can work, but I don't think it should be the default behavior, because the widget now tries to be quite adherent to the concept of groups and levels as in xkb. After all, in the case James showed, the same key label is shown multiple times because the same keysym will be generated at different levels.
(In reply to Antonio Ospite from comment #6) > While James has a point about duplicated key labels not being pretty, I > think that handling just the case of GKBD_KEYBOARD_DRAWING_POS_TOPLEFT like > the current patch does is not general enough. > > Maybe some option to say "if _all_ key labels are the same just show one of > them" can work, but I don't think it should be the default behavior, because > the widget now tries to be quite adherent to the concept of groups and > levels as in xkb. I don't think that the widget's default behaviour should be based on whether it can be used as a keymap debugging tool. > After all, in the case James showed, the same key label is shown multiple > times because the same keysym will be generated at different levels.
Review of attachment 236196 [details] [review]: If you show only the top-left keysym, there's no way to differentiate between a key having the same key on all 4 levels, and a key having a keysym for only one level. Instead, it should probably be drawn to take the whole key, so it's obvious what the keysym would be.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/libgnomekbd/-/issues/ Thank you for your understanding and your help.