After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693798 - Replace add_to_scrolled() with GtkScrolled interface extension
Replace add_to_scrolled() with GtkScrolled interface extension
Status: RESOLVED FIXED
Product: egg-list-box
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: egg-list-box-maint
egg-list-box-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-14 14:29 UTC by Florian Müllner
Modified: 2017-07-12 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't use gtk_scrolled_window_add_with_viewport() (1.40 KB, patch)
2013-02-14 14:29 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-02-14 14:29:26 UTC 
This is a drive-by patch to get rid of some compiler warnings, but:

<alex> fmuellner: I talked to cosimoc about that. We want to also have the set_adjustment thing handled automatically, by extending the scrollable iface
<alex> fmuellner: so that add_to_scrolled is not needed at all
alex> fmuellner: can you please file a bug with it so we don't forget?

Here we are then - feel free to reassign to GTK+ if you consider that a better place (for the interface change) ...
Comment 1 Florian Müllner 2013-02-14 14:29:28 UTC 
Created attachment 236061 [details] [review]
Don't use gtk_scrolled_window_add_with_viewport()

It has recently been deprecated in favor of gtk_container_add().
Comment 2 Alexander Larsson 2013-02-14 19:54:42 UTC 
Comment on attachment 236061 [details] [review]
Don't use gtk_scrolled_window_add_with_viewport()

Attachment 236061 [details] pushed as fefe93f - Don't use gtk_scrolled_window_add_with_viewport()
Comment 3 Alexander Larsson 2013-02-14 19:55:37 UTC 
I pushed this, but we should still replace add_to_scrolled()
Comment 4 Florian Müllner 2017-07-12 14:42:42 UTC 
The patch was pushed and GtkListBox has superseded EggListBox since then, so closing.