GNOME Bugzilla – Bug 693688
classic-mode: app launch spinner does not turn black
Last modified: 2013-04-16 17:28:58 UTC
I've noticed that the spinner we show for startup feedback is still white, while all the other text on the top bar is turned black.
Known problem, see http://git.gnome.org/browse/gnome-shell-extensions/tree/data/gnome-classic.css#n3
So, the spinner is done as AnimatedIcon('process-working.svg') I guess we could either make that smart about symbolic icon recoloring, or just choose a different svg depending on the mode
Created attachment 240994 [details] [review] classic: Invert the spinner color
Review of attachment 240994 [details] [review]: ::: js/ui/panel.js @@ +298,2 @@ this._stop = true; + if (Main.sessionMode.currentMode == 'classic') ugh. I'd rather have a special CSS property here that you would grab with a new lookup_url method on the theme node. Florian has the last say, though.
I agree, we have a generic mechanism for mode specific styling that should be used here.
I don't know enough shell internals to do that. Can either of you please do what's required here ?
Created attachment 241654 [details] [review] panel: Pass a full pathname to AnimatedIcon For classic mode, we want to use a different styling for the spinner, so we will pick up the image filename from CSS to make use of mode specific styling. As the CSS will give us a full pathname, adapt the API to take a full pathname instead of building it inside AnimatedIcon from the passed basename.
Created attachment 241655 [details] [review] theme-node: Add lookup_url/get_url() methods Similar to the existing generic getter methods, add lookup functions for URL properties like the standard background-image/border-image properties.
Created attachment 241656 [details] [review] panel: Pick up spinner icon from CSS In order to use a different spinner image in classic mode (or any other mode specific style), get it from CSS rather than hardcoding a particular image.
Created attachment 241657 [details] [review] classic: Style startup spinner differently in classic mode
Review of attachment 241654 [details] [review]: Hm. I'd imagine that Panel.AnimatedIcon would gain a style class, and use that internally, but OK.
Review of attachment 241655 [details] [review]: OK.
Review of attachment 241656 [details] [review]: OK.
Review of attachment 241657 [details] [review]: OK.
Attachment 241654 [details] pushed as 2fc76e6 - panel: Pass a full pathname to AnimatedIcon Attachment 241655 [details] pushed as 2b439ef - theme-node: Add lookup_url/get_url() methods Attachment 241656 [details] pushed as 4710753 - panel: Pick up spinner icon from CSS
Attachment 241657 [details] pushed as 4ebd46c - classic: Style startup spinner differently in classic mode